fix: missing dash style in line annotation#692
Merged
markov00 merged 2 commits intoelastic:masterfrom Jun 1, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 72.78% 73.21% +0.42%
==========================================
Files 255 270 +15
Lines 8437 8744 +307
Branches 1674 1719 +45
==========================================
+ Hits 6141 6402 +261
- Misses 2255 2296 +41
- Partials 41 46 +5
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Jun 1, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, Nice quick fix!
Collaborator
Author
|
🎉 This PR is included in version 19.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [19.4.1](elastic/elastic-charts@v19.4.0...v19.4.1) (2020-06-01) ### Bug Fixes * missing dash style in line annotation ([opensearch-project#692](elastic/elastic-charts#692)) ([62999bc](elastic/elastic-charts@62999bc)), closes [opensearch-project#687](elastic/elastic-charts#687)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix re-adds the dash style for line annotations. This probably was an existing feature before we removed Konva library, the story
annotations/lines/5_styling.tsxhas references todashWidthanddashGapWidthused on the line style.The VRT was manually updated as with the current change threshold (0,005% of the whole image) the change is not surfaced. I will open a subsequent PR to check if we can safely remove this threshold
fix #687
Checklist
Delete any items that are not applicable to this PR.
src/index.ts(and stories only import from../srcexcept for test data & storybook)