feat(partition): linked text maximum length config#665
Merged
monfera merged 3 commits intoelastic:masterfrom May 7, 2020
Merged
feat(partition): linked text maximum length config#665monfera merged 3 commits intoelastic:masterfrom
monfera merged 3 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 72.94% 72.97% +0.03%
==========================================
Files 266 266
Lines 8618 8634 +16
Branches 1695 1698 +3
==========================================
+ Hits 6286 6301 +15
- Misses 2293 2294 +1
Partials 39 39
Continue to review full report at Codecov.
|
markov00
approved these changes
May 7, 2020
Collaborator
markov00
left a comment
There was a problem hiding this comment.
LGTM, left a small side note
| const stemToY = cy; | ||
| const text = rawTextGetter(node); | ||
| const rawText = rawTextGetter(node); | ||
| const text = rawText.length <= maxTextLength ? rawText : `${rawText.substr(0, maxTextLength - 1)}…`; // ellipsis is one char |
Collaborator
There was a problem hiding this comment.
it's fine for now, in the future we should account for RTL languages :)
Contributor
Author
There was a problem hiding this comment.
Indeed, thanks for the nudge, will incorporate in the follow-up.
Collaborator
|
🎉 This PR is included in version 19.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.3.0](elastic/elastic-charts@v19.2.0...v19.3.0) (2020-05-08) ### Bug Fixes * build/type issue with DataGenerator ([opensearch-project#671](elastic/elastic-charts#671)) ([01844ac](elastic/elastic-charts@01844ac)) ### Features * **partition:** linked text maximum length config ([opensearch-project#665](elastic/elastic-charts#665)) ([e37cb8f](elastic/elastic-charts@e37cb8f))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows a configuration of maximum text length (in characters) for linked labels on pie and donut charts
Mitigates #633
Ticks a checkbox in #518
Checklist
Delete any items that are not applicable to this PR.
Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)Unit tests were updated or added to match the most common scenarios<- in follow-up PR for adaptive length constraints