fix: empty charts causing errors#657
Merged
markov00 merged 2 commits intoelastic:masterfrom Apr 30, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 72.92% 72.94% +0.01%
==========================================
Files 266 266
Lines 8603 8618 +15
Branches 1690 1695 +5
==========================================
+ Hits 6274 6286 +12
- Misses 2290 2293 +3
Partials 39 39
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Apr 30, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, fixes issue raised in kibana
markov00
pushed a commit
that referenced
this pull request
Apr 30, 2020
## [19.1.1](v19.1.0...v19.1.1) (2020-04-30) ### Bug Fixes * render charts without series ([#657](#657)) ([0c0af01](0c0af01))
Collaborator
Author
|
🎉 This PR is included in version 19.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [19.1.1](elastic/elastic-charts@v19.1.0...v19.1.1) (2020-04-30) ### Bug Fixes * render charts without series ([opensearch-project#657](elastic/elastic-charts#657)) ([311f04a](elastic/elastic-charts@311f04a))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix the error thrown when a chart is rendered without a series spec, usually caused how the consumer renders the chart components.
See the playground example and the comment here: elastic/kibana#64759 (comment)
Checklist
Delete any items that are not applicable to this PR.