fix: tickFormat called on mark value#649
Merged
nickofthyme merged 1 commit intoelastic:masterfrom Apr 24, 2020
Merged
Conversation
rshen91
approved these changes
Apr 24, 2020
Contributor
rshen91
left a comment
There was a problem hiding this comment.
This LGTM - opened storybook locally on Chrome 👍
| expect(tooltipValue.isHighlighted).toBe(false); | ||
| expect(tooltipValue.color).toBe('blue'); | ||
| expect(tooltipValue.value).toBe('10'); | ||
| expect(YAXIS_SPEC.tickFormat).not.toBeCalledWith(null, undefined); |
markov00
pushed a commit
that referenced
this pull request
Apr 24, 2020
## [18.4.2](v18.4.1...v18.4.2) (2020-04-24) ### Bug Fixes * tickFormat called on mark value ([#649](#649)) ([daf6a82](daf6a82))
Collaborator
|
🎉 This PR is included in version 18.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [18.4.2](elastic/elastic-charts@v18.4.1...v18.4.2) (2020-04-24) ### Bug Fixes * tickFormat called on mark value ([opensearch-project#649](elastic/elastic-charts#649)) ([7b84e7f](elastic/elastic-charts@7b84e7f))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark value was being called with the axis
tickFormatfunction with null values. I don't think the mark value would ever be called with an axis formatted so I removed that and just pass the mark value.Checklist