Codecov Report

Merging #552 into master will increase coverage by <.01%.
The diff coverage is 98.07%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   71.49%   71.49%   +<.01%     
==========================================
  Files         208      208              
  Lines        6118     6119       +1     
  Branches     1169     1169              
==========================================
+ Hits         4374     4375       +1     
  Misses       1727     1727              
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2543e2c...6273b43. Read the comment docs.

Can we also remove the function definitions and make this a breaking change with the tooltip logic? That would finish this once and for all.

elastic-charts/src/utils/ids.ts

Lines 1 to 17 in 2242fca

	export function getGroupId(id: string): string {
	return id;
	}
	export function getAxisId(id: string): string {
	return id;
	}
	export function getSpecId(id: string): string {
	return id;
	}
	export function getAnnotationId(id: string): string {
	return id;
	}
	export type GroupId = string;
	export type AxisId = string;
	export type SpecId = string;
	export type AnnotationId = string;

@nickofthyme Sure will do, I will open up a PR for this

LGTM, finally, has this day actually come where we remove all getXXXId??

Side note: I think we should have a react linting rule in place for string and boolean props, what do you think?

// bad
id={'bottom'}
// good
id="bottom"

// bad
showLegend={true}
// good
showLegend

@rshen91 do you want to include also this eslint rule on your PR?