chore: preparation for spec rendering order#516
Merged
markov00 merged 3 commits intoelastic:masterfrom Feb 13, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 208 208
Lines 6118 6118
Branches 1137 1169 +32
=======================================
Hits 4374 4374
Misses 1727 1727
Partials 17 17Continue to review full report at Codecov.
|
ca33298 to
8dede8c
Compare
rshen91
approved these changes
Feb 12, 2020
Contributor
rshen91
left a comment
There was a problem hiding this comment.
These changes LGTM - thanks for updating all the tests and including chart_state.specs.test.ts. I ran this storybook locally and all the stories appeared to be rendering correctly!
markov00
added a commit
that referenced
this pull request
Feb 21, 2020
markov00
added a commit
that referenced
this pull request
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first one to that allow us to implement a valid and clear method to sort the splitted series and allow custom rendering order of bars/area/lines in either chart, legend and tooltips.
This PR in particular clean up few small items:
tooltipValuesarray into an header and an array with only the metric values.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)