Skip to content

fix: add domain fitting for tsvb regression#511

Merged
nickofthyme merged 3 commits intoelastic:13.5from
nickofthyme:backport/13.5/pr-510
Jan 10, 2020
Merged

fix: add domain fitting for tsvb regression#511
nickofthyme merged 3 commits intoelastic:13.5from
nickofthyme:backport/13.5/pr-510

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Jan 9, 2020 •
edited
Loading

Backports the following commits to 13.5:

All changes to prettier and eslint were removed for simplicity. Only cherry-picked commit 4b56729 with changes based on target branch.

@nickofthyme
feat: add domain fitting (elastic#510)
444af6e 
* Add option to fit y domain to data
@nickofthyme nickofthyme changed the title [13.5] feat: add domain fitting (#510) feat: add domain fitting (#510) Jan 9, 2020
@nickofthyme nickofthyme changed the title feat: add domain fitting (#510) feat: add domain fitting Jan 9, 2020
@nickofthyme nickofthyme requested a review from markov00 January 9, 2020 23:58
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 10, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (13.5@3301b36). Click here to learn what that means.
The diff coverage is 95.65%.

Impacted file tree graph

@@           Coverage Diff           @@
##             13.5     #511   +/-   ##
=======================================
  Coverage        ?   97.36%           
=======================================
  Files           ?       41           
  Lines           ?     2880           
  Branches        ?      681           
=======================================
  Hits            ?     2804           
  Misses          ?       67           
  Partials        ?        9
Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/specs.ts 100% <ø> (ø)
src/chart_types/xy_chart/domains/y_domain.ts 97.11% <100%> (ø)
src/utils/domain.ts 97.29% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3301b36...5b43cf5. Read the comment docs.

@nickofthyme nickofthyme changed the title feat: add domain fitting fix: add domain fitting for tsvb regression Jan 10, 2020
@nickofthyme nickofthyme merged commit bcd08b7 into elastic:13.5 Jan 10, 2020
@nickofthyme nickofthyme deleted the backport/13.5/pr-510 branch January 10, 2020 01:25
markov00 pushed a commit that referenced this pull request Jan 10, 2020
@semantic-release-bot
chore(release): 13.5.13 [skip ci]
ff61599 
## [13.5.13](v13.5.12...v13.5.13) (2020-01-10)

### Bug Fixes

* add domain fitting for tsvb regression ([#511](#511)) ([bcd08b7](bcd08b7)), closes [#510](#510)
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Jan 10, 2020

🎉 This PR is included in version 13.5.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 Awaiting requested review from markov00

Assignees

No one assigned

Labels

backport regression released on @13.5.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickofthyme @codecov-io @markov00