refactor: decouple legend and tooltip phase 1 #491
Merged
markov00 merged 6 commits intoelastic:masterfrom Feb 14, 2020
Merged
Conversation
monfera
approved these changes
Dec 12, 2019
Contributor
monfera
left a comment
There was a problem hiding this comment.
Looks good so far, I only have some naming suggestions
monfera
reviewed
Dec 12, 2019
monfera
reviewed
Dec 12, 2019
dca75da to
e31cf93
Compare
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 71.78% 71.49% -0.29%
==========================================
Files 208 208
Lines 6216 6119 -97
Branches 1199 1169 -30
==========================================
- Hits 4462 4375 -87
+ Misses 1738 1727 -11
- Partials 16 17 +1
Continue to review full report at Codecov.
|
markov00
added a commit
that referenced
this pull request
Feb 21, 2020
Move `Datum`, `Rotation`, `Position` and `Color` to `utils/commons`. Decouple legend from axis position method and move the `scales` to `utils/scales`.
markov00
added a commit
that referenced
this pull request
Mar 2, 2020
Move `Datum`, `Rotation`, `Position` and `Color` to `utils/commons`. Decouple legend from axis position method and move the `scales` to `utils/scales`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the first phase to clean and decouple the current code for legend and tooltip from the XYChart dependency.
In this PR I've just moved out 3 types
Rotation,DatumandPositionfrom the XYChart to the mainsrc/utils/commons.tsand I've also moved 1 level up thescalesfolderChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials