fix(crosshair): hide horizontal line when the pointer is outside chart#484
Merged
markov00 merged 1 commit intoelastic:masterfrom Dec 5, 2019
Merged
Conversation
This commit fix the visibility of the crosshair horizontal line, hiding it when the pointer projected position is outside the chart area. fix elastic#483
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=========================================
- Coverage 83.77% 83.7% -0.08%
=========================================
Files 158 169 +11
Lines 4703 4853 +150
Branches 952 966 +14
=========================================
+ Hits 3940 4062 +122
- Misses 748 775 +27
- Partials 15 16 +1
Continue to review full report at Codecov.
|
Collaborator
Author
|
🎉 This PR is included in version 15.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [15.0.2](elastic/elastic-charts@v15.0.1...v15.0.2) (2019-12-05) ### Bug Fixes * **crosshair:** hide horizontal line when the pointer is outside chart ([opensearch-project#484](elastic/elastic-charts#484)) ([bb52d35](elastic/elastic-charts@bb52d35)), closes [opensearch-project#483](elastic/elastic-charts#483)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit fix the visibility of the crosshair horizontal line, hiding
it when the pointer projected position is outside the chart area.
fix #483
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)![ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials