Merged
Conversation
emmacunningham
previously approved these changes
Feb 6, 2019
Contributor
emmacunningham
left a comment
There was a problem hiding this comment.
Code LGTM (just left a couple of questions for my own clarification); tested locally on Firefox.
snide
reviewed
Feb 6, 2019
ce84d0e to
49d84da
Compare
49d84da to
5b7445f
Compare
I've updated the theme structure after the reviews
emmacunningham
approved these changes
Feb 13, 2019
Contributor
emmacunningham
left a comment
There was a problem hiding this comment.
Just a couple of minor comments otherwise LGTM. Thanks for doing all the Theme refactoring!
ca797f7 to
f4ad52e
Compare
The Dark Theme is now available. The AxisConfig has now a cleaner styling, splitted by axis or tick styles. Changing a theme is now easier and it's not necessary tied to a darkmode flag. New theme can be added and used on the charts. fix elastic#35 BREAKING CHANGE: The `Theme.AxisConfig` type has a different signature. It now contains `axisTitleStyle`, `axisLineStyle`, `tickLabelStyle` and `tickLineStyle` defined as `TextStyle` or `StrokeStyle` elements. The `Theme` interface is changed in a more flat structure. `darkMode` prop from `Setting` is removed. `theme` prop in `Setting` is now a `Theme` type object, not a `PartialTheme`. You can use `mergeWithDefaultTheme` function to merge an existing theme with a partial one.
f4ad52e to
93c9f2b
Compare
markov00
pushed a commit
that referenced
this pull request
Feb 19, 2019
# [2.0.0](v1.1.1...v2.0.0) (2019-02-19) ### Features * add dark theme ([#44](#44)) ([766f1ad](766f1ad)), closes [#35](#35) ### BREAKING CHANGES * The `Theme.AxisConfig` type has a different signature. It now contains `axisTitleStyle`, `axisLineStyle`, `tickLabelStyle` and `tickLineStyle` defined as `TextStyle` or `StrokeStyle` elements. The `Theme` interface is changed in a more flat structure. `darkMode` prop from `Setting` is removed. `theme` prop in `Setting` is now a `Theme` type object, not a `PartialTheme`. You can use `mergeWithDefaultTheme` function to merge an existing theme with a partial one.
Collaborator
Author
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [2.0.0](elastic/elastic-charts@v1.1.1...v2.0.0) (2019-02-19) ### Features * add dark theme ([opensearch-project#44](elastic/elastic-charts#44)) ([bf772a0](elastic/elastic-charts@bf772a0)), closes [opensearch-project#35](elastic/elastic-charts#35) ### BREAKING CHANGES * The `Theme.AxisConfig` type has a different signature. It now contains `axisTitleStyle`, `axisLineStyle`, `tickLabelStyle` and `tickLineStyle` defined as `TextStyle` or `StrokeStyle` elements. The `Theme` interface is changed in a more flat structure. `darkMode` prop from `Setting` is removed. `theme` prop in `Setting` is now a `Theme` type object, not a `PartialTheme`. You can use `mergeWithDefaultTheme` function to merge an existing theme with a partial one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce the a better theming on charts. Now the theme has a clear and flatter structure.
A new theme is added:
DARK_THEME.A switch to test the DARK theme is added to storybook
fix #35
BREAKING CHANGES:
The
Themeinterface was refactored completely with a flatter structure.