fix: seedrandom dependency#424
Merged
nickofthyme merged 2 commits intoelastic:masterfrom Oct 17, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 39 39
Lines 2896 2896
Branches 701 701
=======================================
Hits 2834 2834
Misses 55 55
Partials 7 7Continue to review full report at Codecov.
|
2 tasks
markov00
pushed a commit
that referenced
this pull request
Oct 17, 2019
## [13.5.4](v13.5.3...v13.5.4) (2019-10-17) ### Bug Fixes * seedrandom dependency ([#424](#424)) ([2670d28](2670d28))
Collaborator
|
🎉 This PR is included in version 13.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [13.5.4](elastic/elastic-charts@v13.5.3...v13.5.4) (2019-10-17) ### Bug Fixes * seedrandom dependency ([opensearch-project#424](elastic/elastic-charts#424)) ([2e4ed33](elastic/elastic-charts@2e4ed33))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seedRandomwas introduced to facilitate visual testing with consistent "random" data.This PR abstracts the seedFunction from the
DataGeneratorclass to allow arandomNumberGeneratorfunction as an option in the constructor, otherwise defaults toMath.random.fixes #422
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)