fix: move seedrandom to dependency list#423
Closed
markov00 wants to merge 1 commit intoelastic:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 39 39
Lines 2896 2896
Branches 701 701
=======================================
Hits 2834 2834
Misses 55 55
Partials 7 7Continue to review full report at Codecov.
|
Collaborator
Author
|
close in favour of #424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We are shipping the project with
seedrandomas devDependency.Since this is used in
DataGeneratorthat is exposed as public module we should move theseedrandomdevDependency to the dependency list.see Jenkins errors in Kibana: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/5354/console and the updating PR: elastic/kibana#47939
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios