fix: align series names on splitted series configuration#421
Merged
markov00 merged 1 commit intoelastic:masterfrom Oct 17, 2019
Merged
fix: align series names on splitted series configuration#421markov00 merged 1 commit intoelastic:masterfrom
markov00 merged 1 commit intoelastic:masterfrom
Conversation
This commit align the series name when using a splitted series accessor. The names of the series now uses the value coming from the splitted series accessor, independentely on how many series are computed fix elastic#420
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 97.85% 97.85% +<.01%
==========================================
Files 39 39
Lines 2894 2896 +2
Branches 700 701 +1
==========================================
+ Hits 2832 2834 +2
Misses 55 55
Partials 7 7
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Oct 17, 2019
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, tooltip label looks good too
rshen91
approved these changes
Oct 17, 2019
Contributor
rshen91
left a comment
There was a problem hiding this comment.
LGTM and I like the added test
Collaborator
Author
|
🎉 This PR is included in version 13.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [13.5.3](elastic/elastic-charts@v13.5.2...v13.5.3) (2019-10-17) ### Bug Fixes * align series names on splitted series configuration ([opensearch-project#421](elastic/elastic-charts#421)) ([d3f2da1](elastic/elastic-charts@d3f2da1)), closes [opensearch-project#420](elastic/elastic-charts#420)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR align the series name when using a splitted series accessor. The names of the series now
uses the value coming from the splitted series accessor, independently on how many series are
computed
fix #420
Before the fix:
After the fix:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials