refactor(typings): prepare for upgrade TS to 3.7#402
Merged
nickofthyme merged 2 commits intoelastic:masterfrom Nov 11, 2019
Merged
refactor(typings): prepare for upgrade TS to 3.7#402nickofthyme merged 2 commits intoelastic:masterfrom
nickofthyme merged 2 commits intoelastic:masterfrom
Conversation
There are currently to main issue that needs to be resolved before upgrading TS to 3.7: a duplicated GeometryStyle type, that I renamed to GeometryStateStyle (the one used on the SharedGeometryStyle), and an issue with the missing layerX and layerY property on the MouseEvent after this PR merged into TS https://github.com/microsoft/TypeScript/pull/32578/files#diff-46fd87925e4552c166ec188712741c3fL10335-L10336
15 tasks
nickofthyme
approved these changes
Oct 3, 2019
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Tested locally, LGTM!
monfera
approved these changes
Oct 4, 2019
Contributor
monfera
left a comment
There was a problem hiding this comment.
Good change; minor: would prefer the regular for (let i = 0; ...)
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 97.39% 97.39% +<.01%
==========================================
Files 41 41
Lines 2875 2876 +1
Branches 675 675
==========================================
+ Hits 2800 2801 +1
Misses 66 66
Partials 9 9
Continue to review full report at Codecov.
|
|
Can this be merged? TypeScript 3.7 has now been released and we'd like to get Kibana upgraded. |
markov00
pushed a commit
that referenced
this pull request
Nov 11, 2019
# [14.0.0](v13.6.0...v14.0.0) (2019-11-11) ### Code Refactoring * **typings:** prepare for upgrade TS to 3.7 ([#402](#402)) ([e2700de](e2700de)) ### BREAKING CHANGES * **typings:** We have a few exported styles, used in the Theme that are changed: SharedGeometryStyle to SharedGeometryStateStyle and GeometryStyle to GeometryStateStyle
Collaborator
Author
|
🎉 This PR is included in version 14.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [14.0.0](elastic/elastic-charts@v13.6.0...v14.0.0) (2019-11-11) ### Code Refactoring * **typings:** prepare for upgrade TS to 3.7 ([opensearch-project#402](elastic/elastic-charts#402)) ([039a587](elastic/elastic-charts@039a587)) ### BREAKING CHANGES * **typings:** We have a few exported styles, used in the Theme that are changed: SharedGeometryStyle to SharedGeometryStateStyle and GeometryStyle to GeometryStateStyle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are currently to main issue that needs to be resolved before upgrading TS to 3.7:
GeometryStyletype, that I renamed toGeometryStateStyle(the one used on theSharedGeometryStylerenamed toSharedGeometryStateStyleto align better its name to its function )layerXandlayerYproperty on the MouseEvent after this PR merged into TS https://github.com/microsoft/TypeScript/pull/32578/files#diff-46fd87925e4552c166ec188712741c3fL10335-L10336 I've switched to useoffsetXandoffsetYthat we are already using on themouseMoveevent listener.BREAKING CHANGE:
We have few exported styles, used in the Theme that are changed:
SharedGeometryStyletoSharedGeometryStateStyleandGeometryStyletoGeometryStateStyle@reviewers please double check locally on your browsers if the behaviour of the mouse and the brush is the same (I've tested it on chrome, safari, firefox and IE11 using various chart configuration in the playground).
ref issue in Kibana: elastic/kibana#47188
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] Proper documentation or storybook story was added for features that require explanation or tutorials