fix: x-scale for linear band charts#384
Conversation
Add respective local directory to tsconfig (i.e. ./.stroybook and ./.playground)
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
+ Coverage 98.25% 98.26% +0.01%
==========================================
Files 38 38
Lines 2801 2818 +17
Branches 661 670 +9
==========================================
+ Hits 2752 2769 +17
Misses 44 44
Partials 5 5
Continue to review full report at Codecov.
|
markov00
left a comment
There was a problem hiding this comment.
LGTM. Tested locally
One side note: IIRC you tried to add .nice()on the scale configuration. Can you please write down what didn't work?
| }); | ||
| } else { | ||
| if (this.minInterval > 0) { | ||
| if (minInterval > 0 && bandwidth > 0) { |
There was a problem hiding this comment.
Would you mind adding a comment before this line specifying that:
- this case happens only on the xScale (minInterval is > 0 only in that case) and when we want to show bars (bandwidth > 0)
- the reason is: we want to avoid displaying inner ticks between bars in a bar chart when using linear x scale: this can be misinterpreted because the bar width can be interpreted as an interval along that scale
|
Yes the I think the issue could be a simple fix but I couldn't get it. I opened a new issue to fix this in the future 👉 #397 |
## [13.0.1](v13.0.0...v13.0.1) (2019-09-27) ### Bug Fixes * x-scale for linear band charts ([#384](#384)) ([daa3b55](daa3b55))
|
🎉 This PR is included in version 13.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [13.0.1](elastic/elastic-charts@v13.0.0...v13.0.1) (2019-09-27) ### Bug Fixes * x-scale for linear band charts ([opensearch-project#384](elastic/elastic-charts#384)) ([16e216d](elastic/elastic-charts@16e216d))
Summary
Add check for
bandwidthto avoid computingminIntervalfor linear band charts.fixes #364
Checklist