feat: compute global y domain on multiple groups#348
Merged
markov00 merged 2 commits intoelastic:masterfrom Aug 26, 2019
Merged
feat: compute global y domain on multiple groups#348markov00 merged 2 commits intoelastic:masterfrom
markov00 merged 2 commits intoelastic:masterfrom
Conversation
This commit add a new property for the series: useDefaultGroupDomain that allows to split series by groupId but keeps and compute the new groupId domain merging it with the global one fix elastic#169
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
- Coverage 98.45% 98.41% -0.04%
==========================================
Files 38 38
Lines 2710 2769 +59
Branches 644 670 +26
==========================================
+ Hits 2668 2725 +57
- Misses 39 41 +2
Partials 3 3
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Aug 26, 2019
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Wow, this is amazing! Well done. All stacked functionality in storybook looks unaffected 🎉
| return mergeYDomainForGroup(dataSeries, groupId, groupSpecs, customDomain); | ||
| }); | ||
|
|
||
| const globalGroupIds: Set<GroupId> = specs.reduce<Set<GroupId>>((acc, { groupId, useDefaultGroupDomain }) => { |
Collaborator
Author
|
🎉 This PR is included in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [10.3.0](elastic/elastic-charts@v10.2.0...v10.3.0) (2019-08-26) ### Features * compute global y domain on multiple groups ([opensearch-project#348](elastic/elastic-charts#348)) ([1a27c87](elastic/elastic-charts@1a27c87)), closes [opensearch-project#169](elastic/elastic-charts#169) [opensearch-project#185](elastic/elastic-charts#185)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #169, fix #185
This feature allows to compute the global Y domain on multiple groups ids.
It collect all the groupIds Y domains and extend them to the max extent.
This provide an easier way to add multiple groups but keep the same domain without need of external domain computation etc.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11