feat: hide tooltip when hover over lines#339
Merged
markov00 merged 3 commits intoelastic:masterfrom Aug 22, 2019
Merged
Conversation
This commit add a new prop for the line annotation to disable the tooltip when hovering over the line fix elastic#324
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 98.51% 98.51% +<.01%
==========================================
Files 38 38
Lines 2691 2692 +1
Branches 635 622 -13
==========================================
+ Hits 2651 2652 +1
Misses 37 37
Partials 3 3
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Aug 22, 2019
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Testing locally, looks good!
Collaborator
Author
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [10.1.0](elastic/elastic-charts@v10.0.1...v10.1.0) (2019-08-22) ### Features * hide tooltip when over line annotation ([opensearch-project#339](elastic/elastic-charts#339)) ([f6db65f](elastic/elastic-charts@f6db65f)), closes [opensearch-project#324](elastic/elastic-charts#324)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the possibility to hide the tooltip when hovering over a line annotation.
It adds a new property for the
<LineAnnotation />component calledhideLinesTooltips.NOTE
this works correctly with horizontal charts (0 or 180 degrees) but doesn't hide the tooltip for 90,-90 degree rotated charts. That because there is an issue on detecting the mouse hover for the marker in those cases.
I'd like to merge this anyway so TSVB can have it in for 7.4
fix #324
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)