fix: shift bars independently from the specs order#302
Merged
markov00 merged 1 commit intoelastic:masterfrom Aug 12, 2019
Merged
fix: shift bars independently from the specs order#302markov00 merged 1 commit intoelastic:masterfrom
markov00 merged 1 commit intoelastic:masterfrom
Conversation
Each bar series needs to be shifted depending on how many bars are clustered. We don't have to shift a bar if we previously have computed a set of lines or area series.
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 98.17% 98.17% +<.01%
==========================================
Files 37 37
Lines 2682 2688 +6
Branches 632 619 -13
==========================================
+ Hits 2633 2639 +6
Misses 44 44
Partials 5 5
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Aug 9, 2019
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Tested locally, LGTM 🚢
markov00
pushed a commit
that referenced
this pull request
Aug 12, 2019
## [9.0.2](v9.0.1...v9.0.2) (2019-08-12) ### Bug Fixes * shift bars independently from the specs order ([#302](#302)) ([1cd934d](1cd934d))
Collaborator
Author
|
🎉 This PR is included in version 9.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [9.0.2](elastic/elastic-charts@v9.0.1...v9.0.2) (2019-08-12) ### Bug Fixes * shift bars independently from the specs order ([opensearch-project#302](elastic/elastic-charts#302)) ([a6a5eab](elastic/elastic-charts@a6a5eab))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each bar series needs to be shifted depending on how many bars are clustered. We don't have to shift a bar if we previously have computed a set of lines or area series.
fix #301
before
after
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials