fix: remove old specs with changed ids#167
Merged
emmacunningham merged 2 commits intoelastic:masterfrom Apr 16, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 36 36
Lines 1849 1849
Branches 239 239
=======================================
Hits 1780 1780
Misses 60 60
Partials 9 9Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Apr 16, 2019
Collaborator
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [3.11.0](elastic/elastic-charts@v3.10.2...v3.11.0) (2019-04-16) ### Bug Fixes * remove old specs with changed ids ([opensearch-project#167](elastic/elastic-charts#167)) ([61128e6](elastic/elastic-charts@61128e6)) ### Features * allow individual series styling ([opensearch-project#170](elastic/elastic-charts#170)) ([b26f4c9](elastic/elastic-charts@b26f4c9))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #158
This PR implements the fix for the issue of SpecComponent updates not clearing the previous spec version when the update involves a specId change. Now, we check if the specId has changed on update, and if so, remove the spec by the previous specId from the chartStore.
Before:
After:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Unit tests were updated or added to match the most common scenarios