fix(axis): ticks generation for linear scale on bar charts#1645
Merged
markov00 merged 7 commits intoelastic:masterfrom Apr 14, 2022
Merged
fix(axis): ticks generation for linear scale on bar charts#1645markov00 merged 7 commits intoelastic:masterfrom
markov00 merged 7 commits intoelastic:masterfrom
Conversation
5 tasks
nickofthyme
approved these changes
Apr 12, 2022
nickofthyme
reviewed
Apr 12, 2022
nickofthyme
pushed a commit
that referenced
this pull request
Apr 14, 2022
# [46.0.0](v45.1.1...v46.0.0) (2022-04-14) ### Bug Fixes * **axis:** ticks generation for linear scale on bar charts ([#1645](#1645)) ([65d0e7d](65d0e7d)) * **axis:** use correct desired tick count based on axis type ([#1646](#1646)) ([512a6cd](512a6cd)) * **deps:** update dependency @elastic/eui to v53 ([#1639](#1639)) ([34bf325](34bf325)) * **deps:** update dependency @elastic/eui to v54 ([#1642](#1642)) ([6eaca0a](6eaca0a)) ### Features * **axes:** option to fit domain to list of annotation `SpecIds` ([#1641](#1641)) ([220350d](220350d)) * **goal:** auto generated linear ticks ([#1637](#1637)) ([5437d8e](5437d8e)) * **legend:** expose sorting function ([#1644](#1644)) ([128114c](128114c)) ### BREAKING CHANGES * **goal:** goal chart now requires domain min and max to be defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We introduced a logic into tick generation to avoid generating denser ticks when rendering bar charts. It also reduce the number of ticks generated in this case, rendering only a set of ticks at nicer rounded intervals.
See screenshot changes for a comparison of what has changed.
Replace #1435
Details
I have introduced a tick rarefication logic in the continuous scale that works only for bar charts. Nothing has changed for line/area as suggested by @monfera #1435 (comment)
TO REVIEWERS: do you consider this as a breaking change?
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)