feat(legend): hide legend item if hideLegendItem on series spec is true#147
Merged
emmacunningham merged 6 commits intoelastic:masterfrom Apr 4, 2019
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 92.9% 92.91% +<.01%
==========================================
Files 33 33
Lines 1495 1497 +2
Branches 166 167 +1
==========================================
+ Hits 1389 1391 +2
Misses 92 92
Partials 14 14
Continue to review full report at Codecov.
|
markov00
approved these changes
Apr 4, 2019
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Code LGTM. Tested locally on chrome
19 tasks
markov00
pushed a commit
that referenced
this pull request
Apr 4, 2019
# [3.7.0](v3.6.0...v3.7.0) (2019-04-04) ### Features * **legend:** hide legend item if hideLegendItem on series spec is true ([#147](#147)) ([6761c2b](6761c2b))
Collaborator
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [3.7.0](elastic/elastic-charts@v3.6.0...v3.7.0) (2019-04-04) ### Features * **legend:** hide legend item if hideLegendItem on series spec is true ([opensearch-project#147](elastic/elastic-charts#147)) ([57c4fda](elastic/elastic-charts@57c4fda))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #137
This PR introduces a new property to the series spec
hideInLegendwhich, when true, will remove the legend item from being visible in the legend list.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.