Skip to content

fix(legend): legend breaking on words#1458

Merged
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:fix-legend-issues
Nov 5, 2021
Merged

fix(legend): legend breaking on words#1458
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:fix-legend-issues

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Nov 2, 2021 •
edited
Loading

Summary

Fix legend related issues including:

  • hyphens css not correctly truncating all cases, particularly : and /.
  • Overflow pushed items longer than the available space.
  • Short legend items being truncated in Windows Chrome

Details

image

Issues

#1011

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)

@nickofthyme nickofthyme added bug Something isn't working :legend Legend related issue :styling Styling related issue :all Applies to all chart types labels Nov 2, 2021
@nickofthyme nickofthyme requested a review from markov00 November 2, 2021 22:59
@nickofthyme nickofthyme linked an issue Nov 2, 2021 that may be closed by this pull request
Legend sizing does not account for scrollbar width #1011
Closed
@nickofthyme nickofthyme marked this pull request as ready for review November 3, 2021 14:38
markov00
markov00 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me!

@nickofthyme nickofthyme merged commit c42be98 into elastic:master Nov 5, 2021
@nickofthyme nickofthyme deleted the fix-legend-issues branch November 5, 2021 15:02
nickofthyme pushed a commit that referenced this pull request Nov 5, 2021
@semantic-release-bot
chore(release): 38.1.5 [skip ci]
098b15e 
## [38.1.5](v38.1.4...v38.1.5) (2021-11-05)

### Bug Fixes

* **legend:** legend breaking on words ([#1458](#1458)) ([c42be98](c42be98))
@nickofthyme
Copy link
Copy Markdown
Collaborator Author

nickofthyme commented Nov 5, 2021

🎉 This PR is included in version 38.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Nov 5, 2021
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this pull request Nov 8, 2021
@nickofthyme
fix(legend): legend breaking on words (elastic#1458)
f9675dd
@nickofthyme nickofthyme mentioned this pull request Nov 8, 2021
Merged
nickofthyme added a commit that referenced this pull request Nov 8, 2021
@nickofthyme
fix(legend): legend breaking on words (#1458) (#1470)
20298fb
nickofthyme pushed a commit that referenced this pull request Nov 8, 2021
@semantic-release-bot
chore(release): 38.0.3 [skip ci]
671fdcd 
## [38.0.3](v38.0.2...v38.0.3) (2021-11-08)

### Bug Fixes

* **legend:** legend breaking on words ([#1458](#1458)) ([#1470](#1470)) ([20298fb](20298fb))
@formgeist formgeist mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

Assignees

No one assigned

Labels

:all Applies to all chart types bug Something isn't working :legend Legend related issue released Issue released publicly :styling Styling related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Legend sizing does not account for scrollbar width

2 participants

@nickofthyme @markov00