fix(xy): remove wrongly represented null/missing values in tooltip#1415
Merged
markov00 merged 9 commits intoelastic:masterfrom Oct 7, 2021
Conversation
nickofthyme
approved these changes
Oct 1, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, tested locally.
monfera
reviewed
Oct 5, 2021
monfera
reviewed
Oct 5, 2021
monfera
reviewed
Oct 5, 2021
monfera
reviewed
Oct 5, 2021
Contributor
monfera
left a comment
There was a problem hiding this comment.
Function-wise looks good!
It'd be prudent to make a VRT test fail if this one regresses in the future, probably via a URL addition in interactions.test.ts plus pointing somewhere
monfera
approved these changes
Oct 7, 2021
Contributor
monfera
left a comment
There was a problem hiding this comment.
LGTM 🎉 good to merge when as CI passes. Thanks for the image test 🖼️
Collaborator
Author
|
jenkins test this please (flaky cross-chart tooltip) |
nickofthyme
pushed a commit
that referenced
this pull request
Oct 15, 2021
# [38.0.0](v37.0.0...v38.0.0) (2021-10-15) ### Bug Fixes * **deps:** update dependency @elastic/eui to v39 ([#1422](#1422)) ([2ee97aa](2ee97aa)) * **goal:** reduce whitespace for circular charts ([#1413](#1413)) ([6517523](6517523)) * **interactions:** change allowBrushingLastHistogramBin to true ([#1396](#1396)) ([9fa9783](9fa9783)) * **xy:** remove wrongly represented null/missing values in tooltip ([#1415](#1415)) ([e5963a3](e5963a3)), closes [#1414](#1414) ### Code Refactoring * scales ([#1410](#1410)) ([a53a2ba](a53a2ba)) ### Features * **scales:** add `LinearBinary` scale type ([#1389](#1389)) ([9f2e427](9f2e427)) * **xy:** adaptive tick raster ([#1420](#1420)) ([200577b](200577b)) * **xy:** apply the data value formatter to data values over bars ([#1419](#1419)) ([e673fc7](e673fc7)) ### BREAKING CHANGES * **interactions:** allowBrushingLastHistogramBucket renamed to allowBrushingLastHistogramBin on the Settings component defaults true and is only applied for histogram type charts * LogScaleOptions.logBase` is now a `number` instead of the object enum `LogBase`. Some edge case data or configuration _might_, with a deemed low likelihood, lead to a situation where the earlier version would have silently not rendered a bar, line or point, while the new code doesn't `catch`, therefore throw an exception (see the last item). General risk of regressions due to the quantity of code changes (altogether 3.5k)
Collaborator
|
🎉 This PR is included in version 38.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A regression was introduced and caused null values to show up on the tooltip when rendering stacked bars and areas.
We fixed that issue including proper testing for the use case.
Details
The file
chart_types/xy_chart/state/selectors/get_tooltip_values_highlighted_geoms.tsis used to pick the tooltip values from the subset of geometries that the current mouse position intersect. A check was introduced in #1226 to check whenever to include or not a null Y value into a tooltip list.That PR also altered the current data flow, allowing nullish value in the
y1orinitialY1to flow down within theindexedGeometryMapto be used on the tooltip, but filtered on the rendering side.This together with a wrong logic and no test on that edge case caused the regression.
Issues
fix #1414
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)