fix(legend): no truncation with single value#1316
Merged
nickofthyme merged 4 commits intoelastic:masterfrom Aug 19, 2021
Merged
fix(legend): no truncation with single value#1316nickofthyme merged 4 commits intoelastic:masterfrom
nickofthyme merged 4 commits intoelastic:masterfrom
Conversation
markov00
approved these changes
Aug 19, 2021
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Code looks good to me.
The legend needs to be anyway redesigned to accommodate more edge cases, but this solves the linked issue
Collaborator
Author
Yup I added the issue to #580 |
nickofthyme
pushed a commit
that referenced
this pull request
Aug 19, 2021
# [34.1.0](v34.0.0...v34.1.0) (2021-08-19) ### Bug Fixes * **goal:** tooltip actual color ([#1302](#1302)) ([dbe9d36](dbe9d36)) * **heatmap:** improve legend item ([#1317](#1317)) ([49c35ce](49c35ce)) * **legend:** no truncation with single value ([#1316](#1316)) ([7ec8a9f](7ec8a9f)) ### Features * **goal:** optional target tick ([#1301](#1301)) ([88adf22](88adf22))
Collaborator
Author
|
🎉 This PR is included in version 34.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with single item legends limiting width of legend.
Details
The legend grid styles logic attempts to create the best fit for all cases. This is not always the case as the limiting size may not be ideal for (a) the number of series and/or (b) the width of the chart, leading to unnecessary white space. This option is configurable via the
verticalWidththeme parameter however in the case of a single value the legend can always be set to the full width.Issues
fixes #1312
Checklist