fix(legend): disable handleLabelClick for one legend item#1134
Merged
rshen91 merged 15 commits intoelastic:masterfrom Apr 26, 2021
Merged
fix(legend): disable handleLabelClick for one legend item#1134rshen91 merged 15 commits intoelastic:masterfrom
rshen91 merged 15 commits intoelastic:masterfrom
Conversation
nickofthyme
requested changes
Apr 22, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Looks like the ItemLabel is still toggleable. We need to update that in addition to the click handler.
Contributor
Author
ah good catch - please see a34bf4a thank you! |
nickofthyme
reviewed
Apr 23, 2021
nickofthyme
reviewed
Apr 23, 2021
nickofthyme
reviewed
Apr 23, 2021
src/chart_types/xy_chart/state/chart_state.accessibility.test.ts
Outdated
Show resolved
Hide resolved
nickofthyme
reviewed
Apr 23, 2021
1 task
nickofthyme
reviewed
Apr 23, 2021
nickofthyme
approved these changes
Apr 26, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments
nickofthyme
pushed a commit
that referenced
this pull request
May 25, 2021
# [29.2.0](v29.1.0...v29.2.0) (2021-05-25) ### Bug Fixes * **legend:** disable handleLabelClick for one legend item ([#1134](#1134)) ([a7242af](a7242af)), closes [#1055](#1055) ### Features * **a11y:** add alt text for all chart types ([#1118](#1118)) ([9e42229](9e42229)), closes [#1107](#1107) * **legend:** specify number of columns on floating legend ([#1159](#1159)) ([c2e4652](c2e4652)), closes [#1158](#1158) * simple screenspace constraint solver ([#1141](#1141)) ([eb11480](eb11480))
Collaborator
|
🎉 This PR is included in version 29.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [29.2.0](elastic/elastic-charts@v29.1.0...v29.2.0) (2021-05-25) ### Bug Fixes * **legend:** disable handleLabelClick for one legend item ([opensearch-project#1134](elastic/elastic-charts#1134)) ([e485174](elastic/elastic-charts@e485174)), closes [opensearch-project#1055](elastic/elastic-charts#1055) ### Features * **a11y:** add alt text for all chart types ([opensearch-project#1118](elastic/elastic-charts#1118)) ([e1c7489](elastic/elastic-charts@e1c7489)), closes [opensearch-project#1107](elastic/elastic-charts#1107) * **legend:** specify number of columns on floating legend ([opensearch-project#1159](elastic/elastic-charts#1159)) ([ed3736e](elastic/elastic-charts@ed3736e)), closes [opensearch-project#1158](elastic/elastic-charts#1158) * simple screenspace constraint solver ([opensearch-project#1141](elastic/elastic-charts#1141)) ([af9dd96](elastic/elastic-charts@af9dd96))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1055
If there is only one legend item, the label will not be able to be clicked to be visible or not. That functionality still works for charts with multiple legend items.
Checklist
Delete any items that are not applicable to this PR.