fix(partition): fix safari highlight bug on single slice#1132
Merged
markov00 merged 4 commits intoelastic:masterfrom Apr 23, 2021
Merged
fix(partition): fix safari highlight bug on single slice#1132markov00 merged 4 commits intoelastic:masterfrom
markov00 merged 4 commits intoelastic:masterfrom
Conversation
nickofthyme
approved these changes
Apr 22, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM Confirm fixes issue.
nickofthyme
pushed a commit
that referenced
this pull request
Apr 23, 2021
# [29.1.0](v29.0.0...v29.1.0) (2021-04-23) ### Bug Fixes * **interaction:** remove unnecessary elements ([#1131](#1131)) ([411042f](411042f)), closes [#1074](#1074) * **partition:** fix safari highlight bug on single slice ([#1132](#1132)) ([4a04063](4a04063)), closes [#1085](#1085) ### Features * **tooltip:** add stickTo option ([#1122](#1122)) ([12417e2](12417e2)), closes [#921](#921)
Collaborator
|
🎉 This PR is included in version 29.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [29.1.0](elastic/elastic-charts@v29.0.0...v29.1.0) (2021-04-23) ### Bug Fixes * **interaction:** remove unnecessary elements ([opensearch-project#1131](elastic/elastic-charts#1131)) ([dde7bdb](elastic/elastic-charts@dde7bdb)), closes [opensearch-project#1074](elastic/elastic-charts#1074) * **partition:** fix safari highlight bug on single slice ([opensearch-project#1132](elastic/elastic-charts#1132)) ([729c179](elastic/elastic-charts@729c179)), closes [opensearch-project#1085](elastic/elastic-charts#1085) ### Features * **tooltip:** add stickTo option ([opensearch-project#1122](elastic/elastic-charts#1122)) ([534f2a3](elastic/elastic-charts@534f2a3)), closes [opensearch-project#921](elastic/elastic-charts#921)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It looks like safari has a rendering issue on circles if rendered entirely applying a strokeWidth instead of the fill.
I've updated the code for the case where we have a single slice at the root level.
fix #1085