Did you mean to use chartIdDescription here?

And I'm also confused by the fact that we are reusing labelledByin the describedBy. Should we introduce a new props called describedBy?

each prop name should follow the camelCase with the first char lowercase, independently if you use them later as component

We should also sanitize this: it's true that in a TS this will throw error if the value is one of the union type, but in the JS compiled world not. This can lead to errors if this heading comes from an user input, or stored string value.
we can have a function that checks and returns/construct the appropriate header based on the input, like:

{label && <HeadingLevel id={chartIdLabel}>{label}</HeadingLevel>}

const ChartLabel = ({headingLevel: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | 'p', id: string, label?: string}) => {
  if(!label) return null;
  
  switch(headingLevel){ 
    case 'h1':
      return <h1 id={id}>{label}</h1>
      ......
   }
}

.....

<ChartLabel id={chartIdLabel} label={label} headingLevel={headingLevel} />

@nickofthyme other suggestions?

And I'm also confused by the fact that we are reusing labelledByin the describedBy. Should we introduce a new props called describedBy?

@markov00 Good catch in #1121 (comment)

Adding a suggestion here so I could target more lines, I think the ariaLabelledBy stuff snuck in by mistake. It should probably be something like:

(I'm suggesting making a new id just for the chartSeriesTypes <dd> because description text can't be structured data so we can't just set an id for the whole <dl> and use that. It's not perfect but it works well enough for a quick description imo.

@rshen91 Feel free to reach out if this suggestion doesn't make any sense! It's a little convoluted.

Woops added this in 6150d2d thank you!

@markov00 Setting the summary id here would be ideal but aria-labelledby can't reliably report structured content so we're better off putting it on a simple string. Reporting just the chart type seems appropriate for a supplemental description (better than nothing, type of situation).

committing in #1118

@rshen91 @markov00

I thought we were going to use p to be less noisy on pages like Dashboards which can have tons of charts.

committing in #1118 thank you!

thanks sorry about that, I was reading the API docs and was marked as h2