feat(a11y): add basic aria-label to canvas element#1084
Merged
rshen91 merged 12 commits intoelastic:masterfrom Mar 25, 2021
Merged
feat(a11y): add basic aria-label to canvas element#1084rshen91 merged 12 commits intoelastic:masterfrom
rshen91 merged 12 commits intoelastic:masterfrom
Conversation
2 tasks
Contributor
Author
|
jenkins test this |
myasonik
approved these changes
Mar 23, 2021
myasonik
left a comment
There was a problem hiding this comment.
It's a start!
It doesn't solve Charts' accessibility issues but it takes the first step.
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 71.55% 71.98% +0.43%
==========================================
Files 381 397 +16
Lines 11914 12229 +315
Branches 2588 2636 +48
==========================================
+ Hits 8525 8803 +278
- Misses 3358 3387 +29
- Partials 31 39 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
markov00
approved these changes
Mar 25, 2021
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Good to merge after solving merge conflicts
Collaborator
|
🎉 This PR is included in version 26.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [26.1.0](elastic/elastic-charts@v26.0.0...v26.1.0) (2021-03-26) ### Features * **a11y:** add basic aria-label to canvas element ([opensearch-project#1084](elastic/elastic-charts#1084)) ([d4b3e4f](elastic/elastic-charts@d4b3e4f)) * **xy_charts:** render legend inside the chart ([opensearch-project#1031](elastic/elastic-charts#1031)) ([b271d09](elastic/elastic-charts@b271d09)), closes [opensearch-project#861](elastic/elastic-charts#861)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
Chartto the canvas element for Cartesian charts. Tested with VoiceOver and safari. Added a jest puppeteer test for the accessibility object model showing that the alternative text is indeed in the AOM.Checklist
Delete any items that are not applicable to this PR.