Skip to content

fix(tooltip): allow explicit boundary element#1049

Merged
nickofthyme merged 3 commits intoelastic:masterfrom
nickofthyme:fix-boundary-error
Mar 4, 2021
Merged

fix(tooltip): allow explicit boundary element#1049
nickofthyme merged 3 commits intoelastic:masterfrom
nickofthyme:fix-boundary-error

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Mar 3, 2021

Summary

fixes #1048

Applies tooltip.boundary to tooltip options.

Screen.Recording.2021-03-03.at.03.10.16.PM.mp4

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added bug Something isn't working :tooltip Related to hover tooltip labels Mar 3, 2021
@nickofthyme nickofthyme changed the title fix: issue with tooltip ignoring explicit boundary fix(tooltip): allow explicit boundary element Mar 3, 2021
@nickofthyme nickofthyme requested a review from markov00 March 3, 2021 22:00
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #1049 (a947e2c) into master (82931f3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files         363      363           
  Lines       11242    11242           
  Branches     2445     2445           
=======================================
  Hits         8185     8185           
  Misses       3043     3043           
  Partials       14       14
Flag Coverage Δ
unittests 72.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rt/renderer/dom/annotations/annotation_tooltip.tsx 89.65% <100.00%> (ø)
src/components/tooltip/tooltip.tsx 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82931f3...0c28c4f. Read the comment docs.

markov00
markov00 approved these changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you probably want to extract the boundary code to a function to reuse it and change it on a single place if need
Not required in this PR

@nickofthyme nickofthyme merged commit 5cf8461 into elastic:master Mar 4, 2021
@nickofthyme nickofthyme deleted the fix-boundary-error branch March 4, 2021 18:28
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this pull request Mar 4, 2021
@nickofthyme
fix(tooltip): allow explicit boundary element (elastic#1049)
3788e4a
@nickofthyme nickofthyme mentioned this pull request Mar 4, 2021
Merged
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this pull request Mar 4, 2021
@nickofthyme
fix(tooltip): allow explicit boundary element (elastic#1049)
32dc918
@nickofthyme nickofthyme mentioned this pull request Mar 4, 2021
Merged
nickofthyme added a commit that referenced this pull request Mar 4, 2021
@nickofthyme
fix(tooltip): allow explicit boundary element (#1049) (#1056)
05d6885
github-actions bot pushed a commit that referenced this pull request Mar 4, 2021
@semantic-release-bot
chore(release): 25.0.2 [skip ci]
f6074c2 
## [25.0.2](v25.0.1...v25.0.2) (2021-03-04)

### Bug Fixes

* **tooltip:** allow explicit boundary element ([#1049](#1049)) ([#1056](#1056)) ([05d6885](05d6885))
github-actions bot pushed a commit that referenced this pull request Mar 5, 2021
@semantic-release-bot
chore(release): 25.1.1 [skip ci]
ad6a2c0 
## [25.1.1](v25.1.0...v25.1.1) (2021-03-05)

### Bug Fixes

* clippedRanges when complete dataset is null ([#1037](#1037)) ([51418d2](51418d2))
* **tooltip:** allow explicit boundary element ([#1049](#1049)) ([5cf8461](5cf8461))
@nickofthyme
Copy link
Copy Markdown
Collaborator Author

nickofthyme commented Mar 5, 2021

🎉 This PR is included in version 25.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Mar 5, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 25.1.1 [skip ci]
67d9a85 
## [25.1.1](elastic/elastic-charts@v25.1.0...v25.1.1) (2021-03-05)

### Bug Fixes

* clippedRanges when complete dataset is null ([opensearch-project#1037](elastic/elastic-charts#1037)) ([e37b4a7](elastic/elastic-charts@e37b4a7))
* **tooltip:** allow explicit boundary element ([opensearch-project#1049](elastic/elastic-charts#1049)) ([118c2b5](elastic/elastic-charts@118c2b5))
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 27, 2026
Open
@renovate renovate bot mentioned this pull request Mar 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working released Issue released publicly :tooltip Related to hover tooltip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip explicit tooltip boundary ignored

3 participants

@nickofthyme @codecov-io @markov00