feat(axis): log scale limit and base options#1032
Merged
nickofthyme merged 32 commits intoelastic:masterfrom Feb 18, 2021
Merged
feat(axis): log scale limit and base options#1032nickofthyme merged 32 commits intoelastic:masterfrom
nickofthyme merged 32 commits intoelastic:masterfrom
Conversation
- Set base of log scales to 10, 2 or e - Set custom min limit of log values, previously hardcoded to 1 - Allow domain to fit full domain of dataset, without crossing 0
- test all limitLogScaleDomain variations - prevent negative domain padding
- move all log options together - fix x domain being different across other xScale getters - update log option wording
markov00
reviewed
Feb 18, 2021
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Few VRTs to fix and also some unit test to refactor with the new implementation (in particular the ones using computeContinuousDataDomain
markov00
approved these changes
Feb 18, 2021
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Good to merge for me.
If you want, you can go back with the previous api-extractor version and remove the last remaining named tuple ContinuousDomain to clean up the API report
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
# [25.1.0](v25.0.1...v25.1.0) (2021-03-01) ### Bug Fixes * rounding values on stacked w percentage charts ([#1039](#1039)) ([ee63a70](ee63a70)) ### Features * **axis:** log scale limit and base options ([#1032](#1032)) ([b38d110](b38d110)) * **partition:** clip text in partition chart fill label ([#1033](#1033)) ([be9bea0](be9bea0))
Collaborator
|
🎉 This PR is included in version 25.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [25.1.0](elastic/elastic-charts@v25.0.1...v25.1.0) (2021-03-01) ### Bug Fixes * rounding values on stacked w percentage charts ([opensearch-project#1039](elastic/elastic-charts#1039)) ([021e836](elastic/elastic-charts@021e836)) ### Features * **axis:** log scale limit and base options ([#1032](elastic/elastic-charts#1032)) ([11f94c6](elastic/elastic-charts@11f94c6)) * **partition:** clip text in partition chart fill label ([opensearch-project#1033](elastic/elastic-charts#1033)) ([7626441](elastic/elastic-charts@7626441))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #916
The main features added in this PR are the following:
Common,BinaryorNatural), viadomain.logBaseandxDomain.logBasedomain.logMinLimitdomain.fitoptionlogMinLimitNo
logMinLimitset, uses full domainyLogBaseChecklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)