feat(axis): log scale improvements and options by nickofthyme · Pull Request #1014 · elastic/elastic-charts

nickofthyme · 2021-02-04T19:20:17Z

Summary

closes #916

The main features added in this PR are the following:

Set base of log scales to 10, 2 or e (Common, Binary or Natural)
Set custom min limit of log values, previously hardcoded to 1
Allow domain to fit full domain of dataset, without crossing 0

`yMinLimit`

No `yMinLimit` set, uses full domain

`yLogBase`

Checklist

Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
Proper documentation or storybook story was added for features that require explanation or tutorials
Unit tests were updated or added to match the most common scenarios

- Set base of log scales to 10, 2 or e - Set custom min limit of log values, previously hardcoded to 1 - Allow domain to fit full domain of dataset, without crossing 0

nickofthyme · 2021-02-08T20:15:01Z

api/charts.api.md

 import { $Values } from 'utility-types';
 import { ComponentType } from 'react';
-import React from 'react';
+import { default as React_2 } from 'react';


@markov00 I was able to fix this error by upgrading the api-extractor but it made these changes to React. Any ideas?

This usually happens when you are using JSX without importing React or when importing react as import * from React but I've checked your PR and it doesn't seem to touch anything like that. I will investigate on it a bit

- test all limitLogScaleDomain variations - prevent negative domain padding

codecov-io · 2021-02-09T23:49:55Z

Codecov Report

Merging #1014 (0e0dbb5) into master (5d32f23) will decrease coverage by 0.04%.
The diff coverage is 91.56%.

@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   72.78%   72.73%   -0.05%     
==========================================
  Files         363      363              
  Lines       11211    11217       +6     
  Branches     2434     2447      +13     
==========================================
- Hits         8160     8159       -1     
- Misses       3037     3044       +7     
  Partials       14       14

Flag	Coverage Δ
unittests	`72.73% <91.56%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../chart_types/heatmap/layout/viewmodel/viewmodel.ts	`4.37% <0.00%> (ø)`
src/chart_types/index.ts	`100.00% <ø> (ø)`
...y_chart/state/selectors/compute_axes_geometries.ts	`100.00% <ø> (ø)`
...t/state/selectors/compute_axis_ticks_dimensions.ts	`100.00% <ø> (ø)`
...chart/state/selectors/compute_series_geometries.ts	`100.00% <ø> (ø)`
src/chart_types/xy_chart/utils/specs.ts	`100.00% <ø> (ø)`
src/scales/constants.ts	`100.00% <ø> (ø)`
src/scales/scale_band.ts	`92.85% <ø> (ø)`
src/specs/settings.tsx	`90.32% <ø> (ø)`
src/utils/common.ts	`88.07% <33.33%> (+2.18%)`	⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d32f23...9999d8b. Read the comment docs.

markov00 · 2021-02-11T14:18:38Z

api/charts.api.md

+    xLogBase: LogBase;
+    xLogMinLimit?: number;
+    yLogBase: LogBase;
+    yLogMinLimit?: number;


We can have multiple Y axis and "ideally" multiple yLogBase
what if we move these option within the Axis and/or within the xDomain props?
let's discuss it

OK see a26fd2c

- move all log options together - fix x domain being different across other xScale getters - update log option wording

markov00

Changes LGTM

# [25.0.0](v24.6.0...v25.0.0) (2021-02-16) ### Bug Fixes * group legend items by label and color ([#999](#999)) ([5d32f23](5d32f23)) ### Features * **axis:** log scale improvements and options ([#1014](#1014)) ([0f52688](0f52688)) ### BREAKING CHANGES * The `LegendActionProps` and the `LegendColorPickerProps`, used to add actions and color picker through the legend now receive an array of `SeriesIdentifiers`

markov00 · 2021-02-16T19:58:45Z

🎉 This PR is included in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This reverts commit 0f52688.

## [25.0.1](v25.0.0...v25.0.1) (2021-02-17) ### Reverts * log scale improvements and options ([#1014](#1014)) ([2189f92](2189f92))

# [25.0.0](elastic/elastic-charts@v24.6.0...v25.0.0) (2021-02-16) ### Bug Fixes * group legend items by label and color ([opensearch-project#999](elastic/elastic-charts#999)) ([ce0bfba](elastic/elastic-charts@ce0bfba)) ### Features * **axis:** log scale improvements and options ([opensearch-project#1014](elastic/elastic-charts#1014)) ([8bac5e8](elastic/elastic-charts@8bac5e8)) ### BREAKING CHANGES * The `LegendActionProps` and the `LegendColorPickerProps`, used to add actions and color picker through the legend now receive an array of `SeriesIdentifiers`

## [25.0.1](elastic/elastic-charts@v25.0.0...v25.0.1) (2021-02-17) ### Reverts * log scale improvements and options ([opensearch-project#1014](elastic/elastic-charts#1014)) ([7aa1ce7](elastic/elastic-charts@7aa1ce7))

nickofthyme added enhancement New feature or request :axis Axis related issue :data Data/series/scales related issue :xy Bar/Line/Area chart related labels Feb 4, 2021

nickofthyme changed the title ~~feat(scales): log scale improvements and options~~ feat(axis): log scale improvements and options Feb 4, 2021

nickofthyme added 3 commits February 5, 2021 10:27

feat(scales): log scale improvements and options

4a91ad8

- Set base of log scales to 10, 2 or e - Set custom min limit of log values, previously hardcoded to 1 - Allow domain to fit full domain of dataset, without crossing 0

chore: tighten Domain and Range types per x and y

42ce439

fix: broken unit tests and types

7ef4e53

nickofthyme force-pushed the log-options branch from 1b72af4 to 7ef4e53 Compare February 5, 2021 17:13

nickofthyme added 6 commits February 5, 2021 11:16

WIP

d6dcfec

Merge branch 'master' into log-options

d9c6125

fix: mixed polarity, area baseline, add vrt, improve tick formatter

ea7868c

test: revert original to args, fix new args

af1c983

fix: upgrade api extractor and fix type issues

52f1e0d

fix: export LogBase type from top

ada219d

nickofthyme requested a review from markov00 February 8, 2021 20:15

nickofthyme commented Feb 8, 2021

View reviewed changes

nickofthyme added 2 commits February 9, 2021 17:41

test: add tests for log changes

c8066f5

- test all limitLogScaleDomain variations - prevent negative domain padding

Merge branch 'master' into log-options

dc3459f

nickofthyme marked this pull request as ready for review February 9, 2021 23:45

markov00 mentioned this pull request Feb 10, 2021

[api-extractor] Imported React global name changed to React_2 microsoft/rushstack#2479

Open

nickofthyme added 2 commits February 10, 2021 10:27

Merge branch 'master' into log-options

c0f2bde

test: update vrt screenshot

fc4eee4

markov00 reviewed Feb 16, 2021

View reviewed changes

nickofthyme added 4 commits February 16, 2021 11:16

Merge branch 'master' into log-options

1a8d6f6

fix: x domain scale issue, refactor log options

a26fd2c

- move all log options together - fix x domain being different across other xScale getters - update log option wording

Merge branch 'master' into log-options

9999d8b

fix: rename options and update api.md

019c3a4

markov00 self-requested a review February 16, 2021 19:09

markov00 reviewed Feb 16, 2021

View reviewed changes

nickofthyme merged commit 0f52688 into elastic:master Feb 16, 2021

nickofthyme deleted the log-options branch February 16, 2021 19:46

markov00 added the released Issue released publicly label Feb 16, 2021

markov00 mentioned this pull request Feb 17, 2021

fix(xy): default min domain for log scales to baseline value #1028

Closed

nickofthyme added a commit that referenced this pull request Feb 17, 2021

Revert "feat(axis): log scale improvements and options (#1014)"

a5e1ec1

This reverts commit 0f52688.

nickofthyme mentioned this pull request Feb 17, 2021

revert: log scale improvements and options (#1014) #1030

Merged

nickofthyme added a commit that referenced this pull request Feb 17, 2021

revert: log scale improvements and options (#1014)

2189f92

This reverts commit 0f52688.

github-actions bot pushed a commit that referenced this pull request Feb 17, 2021

chore(release): 25.0.1 [skip ci]

542ef18

## [25.0.1](v25.0.0...v25.0.1) (2021-02-17) ### Reverts * log scale improvements and options ([#1014](#1014)) ([2189f92](2189f92))

nickofthyme restored the log-options branch February 17, 2021 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(axis): log scale improvements and options#1014

feat(axis): log scale improvements and options#1014
nickofthyme merged 17 commits intoelastic:masterfrom
nickofthyme:log-options

nickofthyme commented Feb 4, 2021 •

edited

Loading

Uh oh!

nickofthyme Feb 8, 2021 •

edited

Loading

Uh oh!

markov00 Feb 10, 2021

Uh oh!

codecov-io commented Feb 9, 2021 •

edited

Loading

Uh oh!

markov00 Feb 11, 2021

Uh oh!

nickofthyme Feb 16, 2021

Uh oh!

markov00 left a comment

Uh oh!

markov00 commented Feb 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nickofthyme commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

yMinLimit

No yMinLimit set, uses full domain

yLogBase

Checklist

Uh oh!

nickofthyme Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markov00 Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

markov00 Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

nickofthyme Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

markov00 left a comment

Choose a reason for hiding this comment

Uh oh!

markov00 commented Feb 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickofthyme commented Feb 4, 2021 •

edited

Loading

`yMinLimit`

No `yMinLimit` set, uses full domain

`yLogBase`

nickofthyme Feb 8, 2021 •

edited

Loading

codecov-io commented Feb 9, 2021 •

edited

Loading