fix: line path with ordered xValues#824
Merged
nickofthyme merged 8 commits intoelastic:masterfrom Sep 17, 2020
Merged
Conversation
nickofthyme
referenced
this pull request
Sep 15, 2020
This commit adds the wiggle and silhouette stacks mode as available in vislib that allow the creation of streamgraph. It is also to fix fit functions for stacked charts. The commit also add the following fixes: - fit functions are now available also on stacked charts - the legend extra value is now displayed, on-demand, only on charts with a continuous x-axis - Adjusts slightly the way fitted data is represented in the case of null values and no fit option specified. It renders an empty area in this case - for zero-based charts (bar and area charts) the fit option doesn't have any effects - djusts the clipped ranges for ordinal charts, where the lines where wrongly clipped due to a missing translate call when rendering BREAKING CHANGE: the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`. fix #766 fix #715 close #450
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
+ Coverage 74.07% 74.09% +0.02%
==========================================
Files 277 277
Lines 9436 9440 +4
Branches 2037 2037
==========================================
+ Hits 6990 6995 +5
+ Misses 2437 2436 -1
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
markov00
approved these changes
Sep 17, 2020
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Tested locally, works great
I've added a small comment to improve the testing
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
markov00
pushed a commit
that referenced
this pull request
Sep 17, 2020
## [21.3.1](v21.3.0...v21.3.1) (2020-09-17) ### Bug Fixes * line path with ordered xValues ([#824](#824)) ([5a73a3a](5a73a3a))
Collaborator
|
🎉 This PR is included in version 21.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [21.3.1](elastic/elastic-charts@v21.3.0...v21.3.1) (2020-09-17) ### Bug Fixes * line path with ordered xValues ([opensearch-project#824](elastic/elastic-charts#824)) ([8568adc](elastic/elastic-charts@8568adc))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #823
re-fixes #680
Fix line path with ordered
xValuesonOrdinalscales.Before
After
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)