Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/elastic-charts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.7.1
Choose a base ref
...
head repository: elastic/elastic-charts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.7.2
Choose a head ref
  • 3 commits
  • 23 files changed
  • 2 contributors

Commits on Apr 8, 2019

  1. test(canvas): test text bbox calculator on real canvas (#153) 

    Removed the jest-canvas-mock package that doesn't use any canvas implementation, substitute the existing test environment with jsdom 14 and updated canvas.
Removed an old mock of getContext inside the enzime setup.
Increased the scale font size for the bbox calculator and configured few tests for that, to fix the relative issue on chrome.
Canvas on node depends on the os, installed library, fonts etc. This commit checks for a maximum difference between the expected value of the measured text of 2px.
This commit also revisit the chart_state test suite decoupling each test from each other.

fix #152
    @markov00
    markov00 authored Apr 8, 2019
    Configuration menu
    Copy the full SHA
    f25ef46 View commit details
    Browse the repository at this point in the history

  2. fix(timescale): consider timezone on axis ticks (#151) 

    The d3-scale function, used to compute axis ticks, compute a discrete and nice rounded number of ticks on a time scale. By the way, this rounding is applied using UTC or local timezone, meaning
that we cannot display a nicely rounded tick if we want to display data in a timezone different from
the local or utc one. This commit includes a new optional prop to each series `timeZone` that can be used to configure this behaviour (default to utc).

fix #130
    @markov00
    markov00 authored Apr 8, 2019
    Configuration menu
    Copy the full SHA
    d860c97 View commit details
    Browse the repository at this point in the history

  3. chore(release): 3.7.2 [skip ci] 

    ## [3.7.2](v3.7.1...v3.7.2) (2019-04-08)

### Bug Fixes

* **timescale:** consider timezone on axis ticks ([#151](#151)) ([d860c97](d860c97)), closes [#130](#130)
    @semantic-release-bot
    semantic-release-bot committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    22659de View commit details
    Browse the repository at this point in the history
Loading