Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/elastic-charts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v19.4.1
Choose a base ref
...
head repository: elastic/elastic-charts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v19.5.0
Choose a head ref
  • 10 commits
  • 1,114 files changed
  • 5 contributors

Commits on Jun 5, 2020

  1. test(vrt): improve vrt config and update tooltip screenshots (#686)

    - add logging inside page context
    - hiddenSelector to hide dom elements
    - screenshotSelector to override selector
    - debug option to pause before screenshot
    - hide axes, increase padding, for better testing
    - add tests for all rotations, placements and boundary types around chart edges
    - update existing tests with new changes
    - tighten threshold to zero for pixel and overall diff
    nickofthyme authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    d747672 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Configuration menu
    Copy the full SHA
    0729f79 View commit details
    Browse the repository at this point in the history
  2. feat(partition): add 4.5 contrast for text in partition slices (#608)

    Updates partition charts to allow for adaptive text color to meet acceptable color contrast ratio. For more information on text contrast see [docs](https://github.com/elastic/elastic-charts/blob/master/docs/0-Intro/1-Overview.mdx#background-colors-and-text-contrast).
    
    BREAKING CHANGE
    Adds `background` to the `Theme` object with the `BackgroundStyle` type that accepts a `color` value as a `string. Note text color might be different after changes from this PR, see docs on how to disable `textContrast` in the partition chart config.
    
    Closes #606
    rshen91 authored Jun 8, 2020
    Configuration menu
    Copy the full SHA
    eded2ac View commit details
    Browse the repository at this point in the history
  3. chore: improve eslint rules and configuration (#689)

    Improve eslint to rules to promote best practices and uniformity across the codebase.
    nickofthyme authored Jun 8, 2020
    Configuration menu
    Copy the full SHA
    0a91351 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    23290be View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. feat: add screenshot functions to partition/goal (#697)

    This commit adds the screenshot function to partition chart and goal charts
    markov00 authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    5581c3c View commit details
    Browse the repository at this point in the history
  2. fix: remove double rendering (#693)

    Fix the double rendering caused by ignoring the fact that the container size > 0 needs to be part of the required flags to initialize the rendering process.
    
    fix #690
    markov00 authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    ebf2748 View commit details
    Browse the repository at this point in the history
  3. chore: remove all cyclical non-type imports (#700)

    - Move cyclical constants to separate files
    - Move cyclical functions to separate files
    - Move some cyclical types into separate files
    - Move tests to new locations
    nickofthyme authored Jun 11, 2020
    Configuration menu
    Copy the full SHA
    c313c63 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Configuration menu
    Copy the full SHA
    2541180 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. chore(release): 19.5.0 [skip ci]

    # [19.5.0](v19.4.1...v19.5.0) (2020-06-15)
    
    ### Bug Fixes
    
    * **tooltip:** show true opaque colors in tooltips ([#629](#629)) ([23290be](23290be)), closes [#628](#628)
    * path of stacked area series with missing values ([#703](#703)) ([2541180](2541180))
    * remove double rendering ([#693](#693)) ([ebf2748](ebf2748)), closes [#690](#690)
    
    ### Features
    
    * **partition:** add 4.5 contrast for text in partition slices ([#608](#608)) ([eded2ac](eded2ac)), closes [#606](#606)
    * add screenshot functions to partition/goal ([#697](#697)) ([5581c3c](5581c3c))
    semantic-release-bot committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4eb0fc3 View commit details
    Browse the repository at this point in the history
Loading