fix: move non-fatal error to helpers#167
Merged
VihasMakwana merged 2 commits intoelastic:mainfrom Jul 23, 2024
Merged
Conversation
AndersonQ
approved these changes
Jul 23, 2024
Co-authored-by: Anderson Queiroz <me@andersonq.me>
VihasMakwana
added a commit
to VihasMakwana/elastic-agent-system-metrics
that referenced
this pull request
Jul 26, 2024
This reverts commit 0f81a1e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A quick fix PR to move
NonFatalErrto helpers.go instead of process.go.This makes sure that
NonFatalErrcompiles for all OS'.Why is it important?
Checklist
CHANGELOG.mdAuthor's Checklist
Related issues