Refactor binary downloads in agent packaging targets#9218
Merged
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
pkoutsovasilis
left a comment
There was a problem hiding this comment.
Overall looks good to me only one comment about closing the resp.body
56c547c to
eec74ca
Compare
|
Contributor
💚 Build Succeeded
History
cc @swiatekm |
michalpristas
approved these changes
Sep 9, 2025
pkoutsovasilis
approved these changes
Sep 9, 2025
Contributor
|
@Mergifyio backport 8.18 8.19 9.0 9.1 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2)
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2)
This was referenced Sep 9, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2)
3 tasks
swiatekm
added a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Sep 9, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function (cherry picked from commit 05f62c2) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
3 tasks
intxgo
pushed a commit
to intxgo/elastic-agent
that referenced
this pull request
Sep 24, 2025
* Clean up artifact download code in packaging * Drop some unused functions * Fix linter warnings * Move http body closing to the inner download function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors how the agent packaging target downloads binaries. The intent is to make it possible to cache the binaries locally and avoid having to redownload them. See #9133 for the full context.
The PR consists of the following changes:
Why is it important?
This makes the download code more maintainable and more performant. It also unlocks further packaging improvements.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Related issues