Adding new configuration setting: agent.upgrade.rollback.window#8065
Merged
ycombinator merged 7 commits intoelastic:mainfrom May 7, 2025
Merged
Adding new configuration setting: agent.upgrade.rollback.window#8065ycombinator merged 7 commits intoelastic:mainfrom
agent.upgrade.rollback.window#8065ycombinator merged 7 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
|
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
a95b2b0 to
624d614
Compare
blakerouse
previously approved these changes
May 2, 2025
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Looks good. All unit tests and integration tests pass. Only failure is related to check-ci and then change to elastic-agent.reference.yml.
pchila
previously approved these changes
May 5, 2025
Member
pchila
left a comment
There was a problem hiding this comment.
Left a couple of nitpicks about the new settings description, not blocking. Feel free to resolve them if you think those are unnecessary.
LGTM
pchila
previously approved these changes
May 6, 2025
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
40ffcbe to
98e3528
Compare
|
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @ycombinator |
pchila
approved these changes
May 7, 2025
v1v
added a commit
to v1v/elastic-agent
that referenced
this pull request
May 8, 2025
* upstream/main: Guard against `nil` pointer dereference (elastic#8107) Generate NOTICE.txt with only modules used by binaries (elastic#8053) Retry enrollment requests when an error is returned, add enrollment timeout (elastic#8056) Changelog for 8.17.6 version (elastic#8062) (elastic#8106) [main][Automation] Update versions (elastic#8098) Allow using beats receivers for self-monitoring (elastic#8031) Adding new configuration setting: `agent.upgrade.rollback.window` (elastic#8065) [Integration Testing] Allow tests to declare themselves as needing a FIPS environment (elastic#8083) fix(agentless): overcome SIGPIPE in agentless promotion pipeline (elastic#8094) ksm autosharing integration configuration update (elastic#8086)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new optional Agent configuration setting,
agent.upgrade.rollback.window. This setting takes a string parseable bytime.Duration(). The default value of this setting is168h(== 7 days). The value of this setting will determine how long after users upgrade an Agent will they be permitted to request a rollback to the previous version of the Agent on disk.Why is it important?
To allow users to perform manual rollbacks of upgraded Elastic Agent within a certain time window.
Checklist
I have made corresponding changes to the documentation./changelog/fragmentsusing the changelog toolDisruptive User Impact
None; this PR adds a new, optional setting. Further, older versions of Elastic Agent will ignore this setting if they encounter it.
How to test this PR locally
Related issues
rollback_windowto elastic agent configuration with a default value of 7d #6881Questions to ask yourself