Skip to content

docker: use the official Red Hat images#7817

Merged
michalpristas merged 9 commits intoelastic:mainfrom
v1v:feauture/use-docker-elastic-images
May 5, 2025
Merged

docker: use the official Red Hat images#7817
michalpristas merged 9 commits intoelastic:mainfrom
v1v:feauture/use-docker-elastic-images

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Apr 10, 2025

What does this PR do?

use the official Red Hat images

Why is it important?

Release engineering team is cleaning up legacy UBI images from Elastic's internal Docker registry. Please use the official Red Hat images instead. The following list of images is planned to be removed on May 16th:

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v added the backport-active-all Automated backport with mergify to all the active branches label Apr 10, 2025
@v1v v1v requested review from a team April 10, 2025 16:49
@v1v v1v self-assigned this Apr 10, 2025
@v1v v1v requested a review from a team as a code owner April 10, 2025 16:49
@v1v v1v requested review from michalpristas and pchila April 10, 2025 16:49
@v1v v1v changed the title docker: use redhat/ubi9 instead of docker.elastic.co/ubi9 docker: use the official Red Hat images Apr 10, 2025
@v1v
Copy link
Copy Markdown
Member Author

v1v commented Apr 10, 2025 


2025-04-10 21:21:48 CEST | > [stage-1  6/10] RUN chmod 0777 /usr/share/elastic-agent &&     usermod -d /usr/share/elastic-agent elastic-agent &&     find /usr/share/elastic-agent/data/elastic-agent-b63eed/components -name "*.yml*" -type f -exec chown elastic-agent:elastic-agent {} ; &&     true:
-- | --
  | 2025-04-10 21:21:48 CEST | 0.230 /bin/sh: line 1: find: command not found

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Apr 11, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 11, 2025

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Apr 11, 2025

@ebeahan , 👋
Could someone from your team please take ownership of this PR and help debug the errors with the official Red Hat image? The previous docker images will be removed by May 15th.

I only raised this PR to help with some email we have received about using the official RH images, so I searched for the consumers and created those PRs. Only Beats and Elastic Agent are using them. Beats is ok, but Elastic Agent no.

Cheers

blakerouse

This comment was marked as outdated.

Sign in to view

@blakerouse blakerouse self-requested a review April 14, 2025 13:52
@blakerouse
Copy link
Copy Markdown
Contributor

blakerouse commented Apr 14, 2025

Sorry I reviewed the diff and it seemed straightforward. Weird that find is missing in that base image.

@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Apr 18, 2025

@michalpristas can you review the errors reported by @v1v and see what's needed to unblock?

@michalpristas
Copy link
Copy Markdown
Contributor

michalpristas commented Apr 24, 2025

note for myself: redhat ubi minimal comes without find or yum.
we need to modify dockerfile so in case base is redhat ubi we do microdnf install findutils

@michalpristas
Copy link
Copy Markdown
Contributor

michalpristas commented Apr 25, 2025

buildkite has issues today, i'm not going to approve this anyways as i'm involved in code changes

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented May 5, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 5, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @michalpristas @v1v

pkoutsovasilis
pkoutsovasilis approved these changes May 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @michalpristas and @v1v

@michalpristas michalpristas merged commit 56f5d90 into elastic:main May 5, 2025
12 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 5, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 5, 2025 •
edited
Loading

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request May 5, 2025
@v1v @mergify
docker: use the official Red Hat images (#7817)
43b885e 
(cherry picked from commit 56f5d90)

# Conflicts:
#	dev-tools/packaging/packages.yml
#	dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
@mergify mergify bot mentioned this pull request May 5, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request May 5, 2025
@v1v @mergify
docker: use the official Red Hat images (#7817)
13079b5 
(cherry picked from commit 56f5d90)

# Conflicts:
#	dev-tools/packaging/packages.yml
#	dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
mergify bot pushed a commit that referenced this pull request May 5, 2025
@v1v @mergify
docker: use the official Red Hat images (#7817)
81cba7f 
(cherry picked from commit 56f5d90)

# Conflicts:
#	dev-tools/packaging/packages.yml
#	dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
This was referenced May 5, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 5, 2025
@v1v @mergify
docker: use the official Red Hat images (#7817)
7b7f79b 
(cherry picked from commit 56f5d90)
@mergify mergify bot mentioned this pull request May 5, 2025
Merged
8 tasks
ebeahan pushed a commit that referenced this pull request May 9, 2025
@mergify @v1v
docker: use the official Red Hat images (#7817) (#8080)
ceec238 
(cherry picked from commit 56f5d90)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
ebeahan added a commit that referenced this pull request May 9, 2025
@mergify @ebeahan
[8.19] (backport #7817) docker: use the official Red Hat images (#8079)
4b9f5d0 
* docker: use the official Red Hat images (#7817)

(cherry picked from commit 56f5d90)

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
ebeahan added a commit that referenced this pull request May 9, 2025
@mergify @ebeahan
[8.18] (backport #7817) docker: use the official Red Hat images (#8078)
af50a9e 
* docker: use the official Red Hat images (#7817)

(cherry picked from commit 56f5d90)

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
ebeahan added a commit that referenced this pull request May 15, 2025
@mergify @ebeahan
[8.17] (backport #7817) docker: use the official Red Hat images (#8077)
f6211c8 
* docker: use the official Red Hat images (#7817)

(cherry picked from commit 56f5d90)

---------
Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

@blakerouse blakerouse Awaiting requested review from blakerouse

1 more reviewer

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michalpristas michalpristas

@v1v v1v

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@v1v @elasticmachine @blakerouse @ebeahan @michalpristas @pkoutsovasilis @pierrehilbert