Only run providers that are referenced in the policy#6169
Merged
blakerouse merged 5 commits intoelastic:mainfrom Dec 2, 2024
Merged
Only run providers that are referenced in the policy#6169blakerouse merged 5 commits intoelastic:mainfrom
blakerouse merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
|
Contributor
|
|
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
reviewed
Nov 29, 2024
Member
swiatekm
left a comment
There was a problem hiding this comment.
Looks good overall, had some questions about the design and intended control flow.
|
andrzej-stencel
approved these changes
Dec 2, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit b811364)
4 tasks
blakerouse
added a commit
that referenced
this pull request
Dec 3, 2024
Open
4 tasks
Member
|
Nice! We need to update the docs to indicate that providers are no longer enabled by default for the first release that will have this change (8.18 I believe): https://www.elastic.co/guide/en/fleet/current/providers.html#disable-providers-by-default Some of the individual providers also indicate they are enabled by default like https://www.elastic.co/guide/en/fleet/current/kubernetes_leaderelection-provider.html CC @kilfoyle |
This was referenced Dec 10, 2024
Merged
orestisfl
pushed a commit
to orestisfl/elastic-agent
that referenced
this pull request
Jan 24, 2025
swiatekm
added a commit
that referenced
this pull request
Jan 24, 2025
We only signal from providers if the emitted data is different from the current state. This caused a bug where the data wasn't ever emitted if it was empty. The provider controller now distinguishes between no data (yet) and empty data. As a result, it's again possible to effectively disable all providers by using a local provider with no data. This is a regression caused by #6114. It doesn't apply to the main and 8.x branches due to #6169 refactoring provider initialisation in those.
6 tasks
swiatekm
added a commit
that referenced
this pull request
Jan 27, 2025
We only signal from providers if the emitted data is different from the current state. This caused a bug where the data wasn't ever emitted if it was empty. The provider controller now distinguishes between no data (yet) and empty data. As a result, it's again possible to effectively disable all providers by using a local provider with no data. This is a regression caused by #6114. It doesn't apply to the main and 8.x branches due to #6169 refactoring provider initialisation in those.
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
We only signal from providers if the emitted data is different from the current state. This caused a bug where the data wasn't ever emitted if it was empty. The provider controller now distinguishes between no data (yet) and empty data. As a result, it's again possible to effectively disable all providers by using a local provider with no data. This is a regression caused by #6114. It doesn't apply to the main and 8.x branches due to #6169 refactoring provider initialisation in those. (cherry picked from commit 8ea9439)
6 tasks
swiatekm
added a commit
that referenced
this pull request
Jan 27, 2025
We only signal from providers if the emitted data is different from the current state. This caused a bug where the data wasn't ever emitted if it was empty. The provider controller now distinguishes between no data (yet) and empty data. As a result, it's again possible to effectively disable all providers by using a local provider with no data. This is a regression caused by #6114. It doesn't apply to the main and 8.x branches due to #6169 refactoring provider initialisation in those. (cherry picked from commit 8ea9439) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
3 tasks
This was referenced Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the Elastic Agent to only run composable providers if they are referenced in the policy.
Why is it important?
This change provides the following benefits:
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E test(covered by unit tests)Disruptive User Impact
None. As it still runs all those that are referenced from the user.
How to test this PR locally
Run the elastic-agent container with just the system integration and notice that it doesn't require access to the Kubernetes API any more.
Related issues