Skip to content

Add all Docker images to K8s integration tests#5790

Merged
rdner merged 1 commit intoelastic:mainfrom
rdner:k8s-wolfi-tests
Oct 16, 2024
Merged

Add all Docker images to K8s integration tests#5790
rdner merged 1 commit intoelastic:mainfrom
rdner:k8s-wolfi-tests

Conversation

@rdner
Copy link
Copy Markdown
Member

@rdner rdner commented Oct 15, 2024 •
edited
Loading

So, we validate all produced images.

Test runtime:

Let me know if the runtime increase is sensible.

@rdner
Add all Docker images to K8s integration tests
d2a4b2e 
So, we validate all produced images.
@rdner rdner added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify labels Oct 15, 2024
@rdner rdner self-assigned this Oct 15, 2024
@rdner rdner mentioned this pull request Oct 15, 2024
Closed
@rdner rdner linked an issue Oct 15, 2024 that may be closed by this pull request
Automate testing of the Wolfi container in Kubernetes #5142
Closed
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Oct 15, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@rdner rdner marked this pull request as ready for review October 15, 2024 16:29
@rdner rdner requested a review from a team as a code owner October 15, 2024 16:29
@rdner rdner requested review from blakerouse and swiatekm October 15, 2024 16:29
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 15, 2024

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@rdner rdner requested review from cmacknz and removed request for swiatekm October 15, 2024 16:29
@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Oct 15, 2024 •
edited
Loading

Looks like the overall time is still lower then the integration tests execution time so we should be good on that end.
Starting 9.0 ubi and basic will be the same so this would mean minus one variant that has to be removed from main.

@ycombinator what do you think?

@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Oct 15, 2024

Looks like the overall time is still lower then the integration tests execution time so we should be good on that end. Starting 9.0 ubi and basic will be the same so this would mean minus one variant that has to be removed from main.

@ycombinator what do you think?

I tend to agree but I'm also wondering: how much more effort would it be to run TestKubernetesAgentStandaloneKustomize for each of the docker variants concurrently?

@rdner
Copy link
Copy Markdown
Member Author

rdner commented Oct 16, 2024

@jlind23 @ycombinator looks like we all agree that the overall runtime of the tests won't change after merging this (because the agent integration tests are running for even longer).

I think changing the test framework to run these images concurrently is out of the scope of this task, here is the issue to follow up #5801

@rdner rdner mentioned this pull request Oct 16, 2024
Open
@rdner rdner merged commit 9e5b8a7 into elastic:main Oct 16, 2024
@rdner rdner deleted the k8s-wolfi-tests branch October 16, 2024 14:52
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
@rdner @mergify
Add all Docker images to K8s integration tests (#5790)
0a2195e 
So, we validate all produced images.

(cherry picked from commit 9e5b8a7)
@mergify mergify bot mentioned this pull request Oct 16, 2024
Merged
pierrehilbert pushed a commit that referenced this pull request Oct 16, 2024
@mergify @rdner
Add all Docker images to K8s integration tests (#5790) (#5803)
cf61cff 
So, we validate all produced images.

(cherry picked from commit 9e5b8a7)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlind23 jlind23 jlind23 approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@rdner rdner

Labels

backport-8.x Automated backport to the 8.x branch with mergify skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automate testing of the Wolfi container in Kubernetes

4 participants

@rdner @elasticmachine @jlind23 @ycombinator