Revert "Add /liveness endpoint to elastic-agent (#4499)"#4583
Merged
cmacknz merged 1 commit intoelastic:mainfrom Apr 16, 2024
Merged
Revert "Add /liveness endpoint to elastic-agent (#4499)"#4583cmacknz merged 1 commit intoelastic:mainfrom
/liveness endpoint to elastic-agent (#4499)"#4583cmacknz merged 1 commit intoelastic:mainfrom
Conversation
This reverts commit 29ce53e.
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Contributor
|
This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
NOTE: |
Member
Author
|
This is going to need to be force merged. |
Member
Author
|
I am going to force merge this once the unit tests pass to ensure this compiles. I am not waiting for the integration tests since I know they won't pass. |
Member
Author
|
Unit tests passed now, force merging. |
|
42.9% Coverage on New Code
0.0% Duplication on New Code
fearful-symmetry
added a commit
to fearful-symmetry/elastic-agent
that referenced
this pull request
Apr 16, 2024
…lastic#4583) This reverts commit eca5bc7.
7 tasks
fearful-symmetry
added a commit
that referenced
this pull request
Apr 24, 2024
* Reapply "Add `/liveness` endpoint to elastic-agent (#4499)" (#4583) This reverts commit eca5bc7. * add behavior to not disable http monitor on reload with nil config, add tests * improve comments * linter * more linter... * fix spelling * check original config state when reloading config * change behavior of config set from overrides * fix tests * add second test to make sure old behavior with hard-coded monitoring config still works * rename method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 29ce53e.
We need this to fix 8.14.0-SNAPSHOT ESS deployments.