Do not fail tests when interrupted connection during upgrade#4533
Merged
rdner merged 1 commit intoelastic:mainfrom Apr 8, 2024
Merged
Conversation
Older agent versions don't properly handle an interrupted connection during the upgrade. So, we need to handle it in tests. The check was introduced in 4ad7824 however it checked a wrong string, it was supposed to check the output of the command not the actual error string.
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
michalpristas
approved these changes
Apr 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Older agent versions don't properly handle an interrupted connection during the upgrade. So, we need to handle it in tests. The check was introduced in 4ad7824 however it checked a wrong string, it was supposed to check the output of the command not the actual error string. (cherry picked from commit 43cb148)
rdner
added a commit
that referenced
this pull request
Apr 8, 2024
…4540) Older agent versions don't properly handle an interrupted connection during the upgrade. So, we need to handle it in tests. The check was introduced in 4ad7824 however it checked a wrong string, it was supposed to check the output of the command not the actual error string. (cherry picked from commit 43cb148) Co-authored-by: Denis <denis.rechkunov@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older agent versions don't properly handle an interrupted connection during the upgrade. So, we need to handle it in tests.
The check was introduced in 4ad7824 however it checked a wrong string, it was supposed to check the output of the command not the actual error string.
Closes #3890