Fixes http.Verifier so it uses its http client#4270
Merged
AndersonQ merged 2 commits intoelastic:mainfrom Feb 15, 2024
Merged
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
NOTE: |
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
also add test with proxy for the downloader and verifier.
b4bc672 to
ef96788
Compare
blakerouse
approved these changes
Feb 15, 2024
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Change looks good, crazy it had a TODO over the line and already had the client in the verifier.
pchila
approved these changes
Feb 15, 2024
Member
pchila
left a comment
There was a problem hiding this comment.
Aside from the small issue in changelog fragment, everything else looks good
…c-Agent-did-not-utilize-the-download-settings-when-downloading-the-artifact-signature-file..yaml Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
michalpristas
approved these changes
Feb 15, 2024
|
100.0% Coverage on New Code
0.0% Duplication on New Code
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
also add test with proxy for the Verifier. (cherry picked from commit 1d63dde)
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
also add test with proxy for the Verifier. (cherry picked from commit 1d63dde)
This was referenced Feb 15, 2024
michalpristas
pushed a commit
that referenced
this pull request
Feb 16, 2024
pierrehilbert
pushed a commit
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the http.Verifier to use its http.Client and extend the tests to also test it uses the proxy.
Why is it important?
The http.Verifier was using the default http client, which does not have the user defined settings.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
follow the Steps to Reproduce from #4237
Related issues
Questions to ask yourself