Skip to content

Add pre-hook to load paths overrides in container#1875

Merged
michalpristas merged 1 commit intoelastic:mainfrom
michalpristas:fix/restart-cont
Dec 2, 2022
Merged

Add pre-hook to load paths overrides in container#1875
michalpristas merged 1 commit intoelastic:mainfrom
michalpristas:fix/restart-cont

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Dec 2, 2022

What does this PR do?

We're loading path overrides in every command and few of them were left unnoticed.
This PR moves the logic to Prehook so paths are always updated in all cases.

Why is it important?

Restart and version does not work in a container
Fixes #1713

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team skip-changelog backport-v8.6.0 Automated backport with mergify labels Dec 2, 2022
@michalpristas michalpristas requested a review from a team as a code owner December 2, 2022 14:27
@michalpristas michalpristas self-assigned this Dec 2, 2022
@michalpristas michalpristas requested review from AndersonQ and blakerouse and removed request for a team December 2, 2022 14:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.7% 7.7% Duplication

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T14:27:42.756+0000

  • Duration: 18 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 4661
Skipped 13
Total 4674

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.082% (143/207) 👍
Classes 69.133% (271/392) 👍
Methods 53.958% (818/1516) 👍
Lines 39.142% (8848/22605) 👍 0.063
Conditionals 100.0% (0/0) 💚

@michalpristas michalpristas merged commit a836d4f into elastic:main Dec 2, 2022
mergify bot pushed a commit that referenced this pull request Dec 2, 2022
@michalpristas @mergify
Add pre-hook to load paths overrides in container (#1875)
e97689b 
(cherry picked from commit a836d4f)
@mergify mergify bot mentioned this pull request Dec 2, 2022
Merged
michalpristas added a commit that referenced this pull request Dec 2, 2022
@mergify @michalpristas
Add pre-hook to load paths overrides in container (#1875) (#1876)
8ce31f3 
(cherry picked from commit a836d4f)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@michalpristas michalpristas

Labels

backport-v8.6.0 Automated backport with mergify bug Something isn't working skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V2: elastic-agent restart command does not work in Docker

3 participants

@michalpristas @elasticmachine @cmacknz