Skip to content

[backport 9.3] Bump Go version to 1.25.8 (#10156)#13142

Merged
swiatekm merged 4 commits into9.3from
backport/9.3/pr-10156
Mar 18, 2026
Merged

[backport 9.3] Bump Go version to 1.25.8 (#10156)#13142
swiatekm merged 4 commits into9.3from
backport/9.3/pr-10156

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

What does this PR do?

Manual backport of #10156

* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
@michel-laterman michel-laterman requested a review from a team as a code owner March 12, 2026 20:56
@michel-laterman michel-laterman added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 12, 2026
@michel-laterman michel-laterman requested a review from a team as a code owner March 12, 2026 20:56
@michel-laterman michel-laterman requested review from blakerouse and ycombinator and removed request for a team March 12, 2026 20:56
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@michel-laterman michel-laterman changed the title [backport] Bump Go version to 1.25.8 (#10156) [backport 9.3] Bump Go version to 1.25.8 (#10156) Mar 12, 2026
Copy link
Copy Markdown
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding on backporting 1.25.8 upgrade to release branches to discuss FIPS related changes.

@swiatekm swiatekm requested a review from ebeahan March 17, 2026 17:10
swiatekm
swiatekm previously approved these changes Mar 17, 2026
@swiatekm
Copy link
Copy Markdown
Member

docker: Error response from daemon: manifest for docker.elastic.co/observability-ci/golang-crossbuild:1.25.8-npcap-1.83-debian11 not found: manifest unknown: manifest unknown

Looks like we don't have Go 1.25.8 crossbuild images for older npcap versions.

ebeahan
ebeahan previously approved these changes Mar 17, 2026
Copy link
Copy Markdown
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing review block. Still need to address CI failures.

@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Mar 17, 2026

Looks like we don't have Go 1.25.8 crossbuild images for older npcap versions.

When Beats was bumped to Go 1.25.8, we also bumped the npcap version to 1.87. Context: elastic/beats#46793 (comment)

Not sure how we deal with it at this point in this branch. Following https://github.com/elastic/golang-crossbuild/blob/main/NPCAP.md#backports to ping 1.25.8.x to npcap 1.83 doesn't seem correct since other branches are actively using the combo of Go 1.25.8 and npcap 1.87 (breakage?).

I also suspect this is a side effect of not being to update Beats yet in #13123

@ebeahan ebeahan dismissed stale reviews from swiatekm and themself via 8201b11 March 17, 2026 21:04
@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Mar 17, 2026

I updated Beats enough to remove the CI failure due to crossbuild: 8201b11.

Is this an acceptable approach? I didn't want to overload this backport by trying to update elastic/beats all the way to current for 9.3; I figured we'll handle that in a separate PR.

@swiatekm
Copy link
Copy Markdown
Member

I updated Beats enough to remove the CI failure due to crossbuild: 8201b11.

Is this an acceptable approach? I didn't want to overload this backport by trying to update elastic/beats all the way to current for 9.3; I figured we'll handle that in a separate PR.

There's a test failure comparing monitoring metadata between beats processes and receivers. I updated to the latest beat version that doesn't include the otel update, hopefully that resolves it.

@swiatekm swiatekm merged commit 68cb476 into 9.3 Mar 18, 2026
24 checks passed
@swiatekm swiatekm deleted the backport/9.3/pr-10156 branch March 18, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants