Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
There is a new Go Vet rule: https://go.dev/doc/go1.25#vet So many builds are breaking with: |
|
The These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround. |
5fab649 to
b49d237
Compare
These errors are coming from Go downloading dependencies before executing the tests. The errors can be simulated like so: I ran into the same problem in elastic/elastic-agent#10156 and I had success with explicitly downloading the dependencies before executing the tests. I'm running into a different problem on that PR now; once it's sorted out, I will apply the same approach on this PR here. Moving this PR into draft until then. |
|
MacOS packaging steps are failing in CI like so (this example is from trying to package Agentbeat): From https://go.dev/doc/go1.25#darwin:
And it looks like we're still using either the 10.11 or 11.3 MacOS SDK in golang-crossbuild images. |
8819cff to
458f432
Compare
|
The packetbeat Windows amd64 build is failing like so: Looking at the images mentioned in https://github.com/elastic/golang-crossbuild/releases/tag/v1.24.13, I'm not seeing docker.elastic.co/observability-ci/golang-crossbuild:1.25.8-npcap-1.83-debian9. |
|
Try bumping npcap to |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (33)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughUpdates Go toolchain from 1.24.13 to 1.25.8, bumps golangci-lint to v2.5.0, and updates cel-go to v0.26.1. Removes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
andrewkroh
left a comment
There was a problem hiding this comment.
Changes to auditbeat and packetbeat look good.
Yes, npcap was upgraded from 1.25.7 onwards. https://github.com/elastic/golang-crossbuild/releases/tag/v1.25.8 contains the entry for npcap: |
|
@Mergifyio backport 8.19 9.2 9.3 |
✅ Backports have been createdDetails
Cherry-pick of c1cb121 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of c1cb121 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of c1cb121 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Bump Go version to 1.25.1 * Bump the version of golangci-lint * Use net.JoinHostPort * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140-only mode * Only modify curve preferences * Fix up fips140=only integration tests * Forgot import * Forgot import * Fix TestConnectionTLS * Set GODEBUG=tlsmlkem=0 for tests * Remove unnecessary changes * Remove pre-download of Go modules * Running mage fmt * Adding CHANGELOG * Fixing IPv6 address * Adding missed import * Go version: s/1.25.2/1.25.4/g * Rebasing, fixing conflicts, and bumping to Go version 1.25.8 * Bump npcap version (cherry picked from commit c1cb121) # Conflicts: # go.sum # libbeat/docs/version.asciidoc
* Bump Go version to 1.25.1 * Bump the version of golangci-lint * Use net.JoinHostPort * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140-only mode * Only modify curve preferences * Fix up fips140=only integration tests * Forgot import * Forgot import * Fix TestConnectionTLS * Set GODEBUG=tlsmlkem=0 for tests * Remove unnecessary changes * Remove pre-download of Go modules * Running mage fmt * Adding CHANGELOG * Fixing IPv6 address * Adding missed import * Go version: s/1.25.2/1.25.4/g * Rebasing, fixing conflicts, and bumping to Go version 1.25.8 * Bump npcap version (cherry picked from commit c1cb121) # Conflicts: # go.sum # libbeat/docs/version.asciidoc
* Bump Go version to 1.25.1 * Bump the version of golangci-lint * Use net.JoinHostPort * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140-only mode * Only modify curve preferences * Fix up fips140=only integration tests * Forgot import * Forgot import * Fix TestConnectionTLS * Set GODEBUG=tlsmlkem=0 for tests * Remove unnecessary changes * Remove pre-download of Go modules * Running mage fmt * Adding CHANGELOG * Fixing IPv6 address * Adding missed import * Go version: s/1.25.2/1.25.4/g * Rebasing, fixing conflicts, and bumping to Go version 1.25.8 * Bump npcap version (cherry picked from commit c1cb121) # Conflicts: # go.sum # libbeat/docs/version.asciidoc
* Bump Go version to 1.25.8 (#46793) * Bump Go version to 1.25.1 * Bump the version of golangci-lint * Use net.JoinHostPort * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140-only mode * Only modify curve preferences * Fix up fips140=only integration tests * Forgot import * Forgot import * Fix TestConnectionTLS * Set GODEBUG=tlsmlkem=0 for tests * Remove unnecessary changes * Remove pre-download of Go modules * Running mage fmt * Adding CHANGELOG * Fixing IPv6 address * Adding missed import * Go version: s/1.25.2/1.25.4/g * Rebasing, fixing conflicts, and bumping to Go version 1.25.8 * Bump npcap version (cherry picked from commit c1cb121) # Conflicts: # go.sum # libbeat/docs/version.asciidoc * Fixing conflicts --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
* Bump Go version to 1.25.8 (#46793) * Bump Go version to 1.25.1 * Bump the version of golangci-lint * Use net.JoinHostPort * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140-only mode * Only modify curve preferences * Fix up fips140=only integration tests * Forgot import * Forgot import * Fix TestConnectionTLS * Set GODEBUG=tlsmlkem=0 for tests * Remove unnecessary changes * Remove pre-download of Go modules * Running mage fmt * Adding CHANGELOG * Fixing IPv6 address * Adding missed import * Go version: s/1.25.2/1.25.4/g * Rebasing, fixing conflicts, and bumping to Go version 1.25.8 * Bump npcap version (cherry picked from commit c1cb121) # Conflicts: # go.sum # libbeat/docs/version.asciidoc * Fixing conflicts --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
* Bump Go version to 1.25.8 (#46793) * Bump Go version to 1.25.1 * Bump the version of golangci-lint * Use net.JoinHostPort * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140-only mode * Only modify curve preferences * Fix up fips140=only integration tests * Forgot import * Forgot import * Fix TestConnectionTLS * Set GODEBUG=tlsmlkem=0 for tests * Remove unnecessary changes * Remove pre-download of Go modules * Running mage fmt * Adding CHANGELOG * Fixing IPv6 address * Adding missed import * Go version: s/1.25.2/1.25.4/g * Rebasing, fixing conflicts, and bumping to Go version 1.25.8 * Bump npcap version (cherry picked from commit c1cb121) # Conflicts: # go.sum # libbeat/docs/version.asciidoc * Fixing conflicts --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
This PR bumps up the Golang version to
1.25.8. It also:ms_tls13kdfGolang build tag when building in FIPS mode because this tag was only needed with Golang versions1.24.x.GODEBUG=tlsmlkem=0environment variable when running FIPS140-only unit tests. This prevents errors like so:Failed to connect: crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.fmt.Sprintf("%s:%d", ip, port)code fragments withnet.JoinHostPort(ip, strconv.Itoa(int(port)))to work with the newhostportgo vetanalyzer.