Skip to content

Bump Go version to 1.25.8#46793

Merged
ycombinator merged 23 commits intoelastic:mainfrom
ycombinator:bump-golang-1.25.1
Mar 6, 2026
Merged

Bump Go version to 1.25.8#46793
ycombinator merged 23 commits intoelastic:mainfrom
ycombinator:bump-golang-1.25.1

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Sep 25, 2025

This PR bumps up the Golang version to 1.25.8. It also:

  • removes the ms_tls13kdf Golang build tag when building in FIPS mode because this tag was only needed with Golang versions 1.24.x.
  • sets ths GODEBUG=tlsmlkem=0 environment variable when running FIPS140-only unit tests. This prevents errors like so: Failed to connect: crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.
  • replaces any fmt.Sprintf("%s:%d", ip, port) code fragments with net.JoinHostPort(ip, strconv.Itoa(int(port))) to work with the new hostport go vet analyzer.

@ycombinator ycombinator requested review from a team as code owners September 25, 2025 17:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 25, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ycombinator? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ycombinator ycombinator added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-active-all Automated backport with mergify to all the active branches labels Sep 25, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 25, 2025
@ycombinator ycombinator requested a review from a team as a code owner September 25, 2025 17:28
Copy link
Copy Markdown
Contributor

@joecompute joecompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@belimawr
Copy link
Copy Markdown
Contributor

There is a new Go Vet rule: https://go.dev/doc/go1.25#vet

So many builds are breaking with:

helper/server/udp/udp_test.go:81:26: address format "%s:%d" does not work with IPv6 (passed to net.Dial at L82)

https://buildkite.com/elastic/beats-metricbeat/builds/24655/steps/canvas?jid=01998236-e28d-40a4-a759-d06b75055f5a#01998236-e28d-40a4-a759-d06b75055f5a/132-385

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Sep 25, 2025

The fips140=only unit tests are failing like so:

crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode

These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Sep 26, 2025

The fips140=only unit tests are failing like so:

crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode

These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround.

These errors are coming from Go downloading dependencies before executing the tests. The errors can be simulated like so:

GODEBUG=fips140=only go mod download -x
# get https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info
# get https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info: Get "https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info": crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode
...

I ran into the same problem in elastic/elastic-agent#10156 and I had success with explicitly downloading the dependencies before executing the tests. I'm running into a different problem on that PR now; once it's sorted out, I will apply the same approach on this PR here. Moving this PR into draft until then.

@ycombinator ycombinator marked this pull request as draft September 26, 2025 05:27
@ycombinator
Copy link
Copy Markdown
Contributor Author

MacOS packaging steps are failing in CI like so (this example is from trying to package Agentbeat):

/usr/local/go/pkg/tool/linux_amd64/link: running o64-clang failed: exit status 1
--
  | /usr/local/osxcross/bin/o64-clang -arch x86_64 -m64 -Wl,-flat_namespace -Wl,-bind_at_load -Wl,-S -Wl,-x -o $WORK/b001/exe/a.out -Qunused-arguments /tmp/go-link-387501915/go.o /tmp/go-link-387501915/000000.o /tmp/go-link-387501915/000001.o /tmp/go-link-387501915/000002.o /tmp/go-link-387501915/000003.o /tmp/go-link-387501915/000004.o /tmp/go-link-387501915/000005.o /tmp/go-link-387501915/000006.o /tmp/go-link-387501915/000007.o /tmp/go-link-387501915/000008.o /tmp/go-link-387501915/000009.o /tmp/go-link-387501915/000010.o /tmp/go-link-387501915/000011.o /tmp/go-link-387501915/000012.o /tmp/go-link-387501915/000013.o /tmp/go-link-387501915/000014.o /tmp/go-link-387501915/000015.o /tmp/go-link-387501915/000016.o /tmp/go-link-387501915/000017.o /tmp/go-link-387501915/000018.o /tmp/go-link-387501915/000019.o /tmp/go-link-387501915/000020.o /tmp/go-link-387501915/000021.o /tmp/go-link-387501915/000022.o /tmp/go-link-387501915/000023.o /tmp/go-link-387501915/000024.o /tmp/go-link-387501915/000025.o /tmp/go-link-387501915/000026.o /tmp/go-link-387501915/000027.o /tmp/go-link-387501915/000028.o /tmp/go-link-387501915/000029.o /tmp/go-link-387501915/000030.o /tmp/go-link-387501915/000031.o /tmp/go-link-387501915/000032.o /tmp/go-link-387501915/000033.o /tmp/go-link-387501915/000034.o /tmp/go-link-387501915/000035.o /tmp/go-link-387501915/000036.o /tmp/go-link-387501915/000037.o /tmp/go-link-387501915/000038.o /tmp/go-link-387501915/000039.o /tmp/go-link-387501915/000040.o /tmp/go-link-387501915/000041.o /tmp/go-link-387501915/000042.o /tmp/go-link-387501915/000043.o /tmp/go-link-387501915/000044.o /tmp/go-link-387501915/000045.o /tmp/go-link-387501915/000046.o -lresolv -lpcap -lpcap -lpcap -lpcap -lproc -framework CoreFoundation -framework Security -lpcap -framework CoreServices -lpcap -lpthread -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap
  | Undefined symbols for architecture x86_64:
  | "_SecTrustCopyCertificateChain", referenced from:
  | _crypto/x509/internal/macos.x509_SecTrustCopyCertificateChain_trampoline.abi0 in go.o
  | ld: symbol(s) not found for architecture x86_64
  | clang: error: linker command failed with exit code 1 (use -v to see invocation)
  |  
  | Error: running "go build -o build/golang-crossbuild/agentbeat-darwin-amd64 -buildmode pie -trimpath -tags=agentbeat -ldflags -s -X github.com/elastic/beats/v7/libbeat/version.buildTime=2025-09-26T23:08:11Z -X github.com/elastic/beats/v7/libbeat/version.commit=cf79447dfa4d2753c13a26766f8b25995a2062fe" failed with exit code 1
  | Error: failed building for darwin/amd64: exit status 1
  | failed building for darwin/amd64: exit status 1

From https://go.dev/doc/go1.25#darwin:

As announced in the Go 1.24 release notes, Go 1.25 requires macOS 12 Monterey or later. Support for previous versions has been discontinued.

And it looks like we're still using either the 10.11 or 11.3 MacOS SDK in golang-crossbuild images.

@ycombinator ycombinator changed the title Bump Go version to 1.25.4 Bump Go version to 1.25.8 Mar 6, 2026
@ycombinator
Copy link
Copy Markdown
Contributor Author

The packetbeat Windows amd64 build is failing like so:

>> Building using: cmd='build/mage-linux-amd64 golangCrossBuild', env=[CC=gcc, CXX=g++, GOARCH=amd64, GOARM=, GOOS=linux, GOTOOLCHAIN=local, PLATFORM_ID=linux-amd64]
--
>> golangCrossBuild: Building for windows/amd64
Unable to find image 'docker.elastic.co/observability-ci/golang-crossbuild:1.25.8-npcap-1.83-debian9' locally
docker: Error response from daemon: manifest for docker.elastic.co/observability-ci/golang-crossbuild:1.25.8-npcap-1.83-debian9 not found: manifest unknown: manifest unknown
 
Run 'docker run --help' for more information
package ran for 3m0.251445462s
Error: failed cross-building target=golangCrossBuild for platform=windows/amd64: running "docker run --ulimit nofile=262144:262144 --env EXEC_UID=1008 --env EXEC_GID=1009 -v /opt/buildkite-agent/.asdf/installs/golang/1.25.8/packages/pkg/mod:/go/pkg/mod:ro --env DEV=false --rm --env GOFLAGS=-mod=readonly -buildvcs=false --env MAGEFILE_VERBOSE= --env MAGEFILE_TIMEOUT= --env SNAPSHOT=false --env FIPS=false -v /opt/buildkite-agent/builds/bk-agent-prod-gcp-1772815911302082922/elastic/beats-xpack-packetbeat:/go/src/github.com/elastic/beats -w /go/src/github.com/elastic/beats/x-pack/packetbeat docker.elastic.co/observability-ci/golang-crossbuild:1.25.8-npcap-1.83-debian9 --build-cmd build/mage-linux-amd64 golangCrossBuild --platforms windows/amd64" failed with exit code 125
🚨 Error: The command exited with status 1

Looking at the images mentioned in https://github.com/elastic/golang-crossbuild/releases/tag/v1.24.13, I'm not seeing docker.elastic.co/observability-ci/golang-crossbuild:1.25.8-npcap-1.83-debian9.

@andrewkroh
Copy link
Copy Markdown
Member

Try bumping npcap to 1.87 in beats. It looks like there was a recent bump in golang-crossbuild to a newer npcap. That image probably exists, and it might just be that the release notes don't generate a line for npcap variant.

elastic/golang-crossbuild#710

@ycombinator ycombinator marked this pull request as ready for review March 6, 2026 17:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7faaa01-56e7-4b22-8fdb-d8dae4379b65

📥 Commits

Reviewing files that changed from the base of the PR and between ecff92b and aa4cd24.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (33)
  • .github/workflows/golangci-lint.yml
  • .go-version
  • NOTICE.txt
  • auditbeat/Dockerfile
  • changelog/fragments/1760385532-bump-golang-1.25.8.yaml
  • dev-tools/kubernetes/filebeat/Dockerfile.debug
  • dev-tools/kubernetes/heartbeat/Dockerfile.debug
  • dev-tools/kubernetes/metricbeat/Dockerfile.debug
  • dev-tools/mage/fips-settings.yaml
  • dev-tools/mage/gotest.go
  • dev-tools/packaging/package_test.go
  • filebeat/magefile.go
  • go.mod
  • heartbeat/Dockerfile
  • heartbeat/hbtest/hbtestutil.go
  • heartbeat/monitors/active/http/http_test.go
  • libbeat/docs/version.asciidoc
  • libbeat/processors/add_kubernetes_metadata/indexers.go
  • libbeat/processors/add_kubernetes_metadata/indexers_test.go
  • metricbeat/Dockerfile
  • metricbeat/helper/server/tcp/tcp_test.go
  • metricbeat/helper/server/udp/udp_test.go
  • metricbeat/magefile.go
  • metricbeat/module/apache/status/status_test.go
  • metricbeat/module/http/_meta/Dockerfile
  • metricbeat/module/vsphere/_meta/Dockerfile
  • packetbeat/Dockerfile
  • testing/go-ech/ech.go
  • x-pack/metricbeat/magefile.go
  • x-pack/metricbeat/module/airflow/statsd/data_test.go
  • x-pack/metricbeat/module/stan/_meta/Dockerfile
  • x-pack/packetbeat/scripts/mage/pcap.go
  • x-pack/packetbeat/tests/system/app_test.go
💤 Files with no reviewable changes (3)
  • dev-tools/packaging/package_test.go
  • testing/go-ech/ech.go
  • dev-tools/mage/fips-settings.yaml

📝 Walkthrough

Walkthrough

Updates Go toolchain from 1.24.13 to 1.25.8, bumps golangci-lint to v2.5.0, and updates cel-go to v0.26.1. Removes ms_tls13kdf tag from FIPS build configuration and adds tlsmlkem=0 to GODEBUG settings in test runners. Replaces manual string formatting of host:port pairs with net.JoinHostPort across multiple test files for IPv6 compatibility. Updates Npcap version from 1.83 to 1.87 in Windows-related files. Adds go mod download step to filebeat integration tests to cache dependencies.

Possibly related PRs

Suggested labels

dependencies

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ycombinator ycombinator enabled auto-merge (squash) March 6, 2026 17:29
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to auditbeat and packetbeat look good.

@v1v
Copy link
Copy Markdown
Member

v1v commented Mar 6, 2026

That image probably exists, and it might just be that the release notes don't generate a line for npcap variant.

Yes, npcap was upgraded from 1.25.7 onwards.

https://github.com/elastic/golang-crossbuild/releases/tag/v1.25.8 contains the entry for npcap:

[1.25](backport https://github.com/elastic/golang-crossbuild/pull/710) Bump npcap to version 1.87 @[mergify[bot]](https://github.com/apps/mergify) (https://github.com/elastic/golang-crossbuild/pull/712)

@ycombinator ycombinator merged commit c1cb121 into elastic:main Mar 6, 2026
208 of 211 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

@Mergifyio backport 8.19 9.2 9.3

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 6, 2026

backport 8.19 9.2 9.3

✅ Backports have been created

Details

Cherry-pick of c1cb121 has failed:

On branch mergify/bp/8.19/pr-46793
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit c1cb121b7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/golangci-lint.yml
	modified:   .go-version
	modified:   NOTICE.txt
	modified:   auditbeat/Dockerfile
	new file:   changelog/fragments/1760385532-bump-golang-1.25.8.yaml
	modified:   dev-tools/kubernetes/filebeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/heartbeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/metricbeat/Dockerfile.debug
	modified:   dev-tools/mage/fips-settings.yaml
	modified:   dev-tools/mage/gotest.go
	modified:   dev-tools/packaging/package_test.go
	modified:   filebeat/magefile.go
	modified:   go.mod
	modified:   heartbeat/Dockerfile
	modified:   heartbeat/hbtest/hbtestutil.go
	modified:   heartbeat/monitors/active/http/http_test.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers_test.go
	modified:   metricbeat/Dockerfile
	modified:   metricbeat/helper/server/tcp/tcp_test.go
	modified:   metricbeat/helper/server/udp/udp_test.go
	modified:   metricbeat/magefile.go
	modified:   metricbeat/module/apache/status/status_test.go
	modified:   metricbeat/module/http/_meta/Dockerfile
	modified:   metricbeat/module/vsphere/_meta/Dockerfile
	modified:   packetbeat/Dockerfile
	modified:   testing/go-ech/ech.go
	modified:   x-pack/metricbeat/magefile.go
	modified:   x-pack/metricbeat/module/airflow/statsd/data_test.go
	modified:   x-pack/metricbeat/module/stan/_meta/Dockerfile
	modified:   x-pack/packetbeat/scripts/mage/pcap.go
	modified:   x-pack/packetbeat/tests/system/app_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.sum
	both modified:   libbeat/docs/version.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of c1cb121 has failed:

On branch mergify/bp/9.2/pr-46793
Your branch is up to date with 'origin/9.2'.

You are currently cherry-picking commit c1cb121b7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/golangci-lint.yml
	modified:   .go-version
	modified:   NOTICE.txt
	modified:   auditbeat/Dockerfile
	new file:   changelog/fragments/1760385532-bump-golang-1.25.8.yaml
	modified:   dev-tools/kubernetes/filebeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/heartbeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/metricbeat/Dockerfile.debug
	modified:   dev-tools/mage/fips-settings.yaml
	modified:   dev-tools/mage/gotest.go
	modified:   dev-tools/packaging/package_test.go
	modified:   filebeat/magefile.go
	modified:   go.mod
	modified:   heartbeat/Dockerfile
	modified:   heartbeat/hbtest/hbtestutil.go
	modified:   heartbeat/monitors/active/http/http_test.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers_test.go
	modified:   metricbeat/Dockerfile
	modified:   metricbeat/helper/server/tcp/tcp_test.go
	modified:   metricbeat/helper/server/udp/udp_test.go
	modified:   metricbeat/magefile.go
	modified:   metricbeat/module/apache/status/status_test.go
	modified:   metricbeat/module/http/_meta/Dockerfile
	modified:   metricbeat/module/vsphere/_meta/Dockerfile
	modified:   packetbeat/Dockerfile
	modified:   testing/go-ech/ech.go
	modified:   x-pack/metricbeat/magefile.go
	modified:   x-pack/metricbeat/module/airflow/statsd/data_test.go
	modified:   x-pack/metricbeat/module/stan/_meta/Dockerfile
	modified:   x-pack/packetbeat/scripts/mage/pcap.go
	modified:   x-pack/packetbeat/tests/system/app_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.sum
	both modified:   libbeat/docs/version.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of c1cb121 has failed:

On branch mergify/bp/9.3/pr-46793
Your branch is up to date with 'origin/9.3'.

You are currently cherry-picking commit c1cb121b7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/golangci-lint.yml
	modified:   .go-version
	modified:   NOTICE.txt
	modified:   auditbeat/Dockerfile
	new file:   changelog/fragments/1760385532-bump-golang-1.25.8.yaml
	modified:   dev-tools/kubernetes/filebeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/heartbeat/Dockerfile.debug
	modified:   dev-tools/kubernetes/metricbeat/Dockerfile.debug
	modified:   dev-tools/mage/fips-settings.yaml
	modified:   dev-tools/mage/gotest.go
	modified:   dev-tools/packaging/package_test.go
	modified:   filebeat/magefile.go
	modified:   go.mod
	modified:   heartbeat/Dockerfile
	modified:   heartbeat/hbtest/hbtestutil.go
	modified:   heartbeat/monitors/active/http/http_test.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers.go
	modified:   libbeat/processors/add_kubernetes_metadata/indexers_test.go
	modified:   metricbeat/Dockerfile
	modified:   metricbeat/helper/server/tcp/tcp_test.go
	modified:   metricbeat/helper/server/udp/udp_test.go
	modified:   metricbeat/magefile.go
	modified:   metricbeat/module/apache/status/status_test.go
	modified:   metricbeat/module/http/_meta/Dockerfile
	modified:   metricbeat/module/vsphere/_meta/Dockerfile
	modified:   packetbeat/Dockerfile
	modified:   testing/go-ech/ech.go
	modified:   x-pack/metricbeat/magefile.go
	modified:   x-pack/metricbeat/module/airflow/statsd/data_test.go
	modified:   x-pack/metricbeat/module/stan/_meta/Dockerfile
	modified:   x-pack/packetbeat/scripts/mage/pcap.go
	modified:   x-pack/packetbeat/tests/system/app_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.sum
	both modified:   libbeat/docs/version.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Mar 6, 2026
* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc
mergify bot pushed a commit that referenced this pull request Mar 6, 2026
* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc
mergify bot pushed a commit that referenced this pull request Mar 6, 2026
* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc
@ycombinator ycombinator deleted the bump-golang-1.25.1 branch March 6, 2026 20:40
ycombinator added a commit that referenced this pull request Mar 6, 2026
* Bump Go version to 1.25.8 (#46793)

* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc

* Fixing conflicts

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
ycombinator added a commit that referenced this pull request Mar 6, 2026
* Bump Go version to 1.25.8 (#46793)

* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc

* Fixing conflicts

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
ycombinator added a commit that referenced this pull request Mar 6, 2026
* Bump Go version to 1.25.8 (#46793)

* Bump Go version to 1.25.1

* Bump the version of golangci-lint

* Use net.JoinHostPort

* Remove references to the ms_tls13kdf build tag

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Download go module dependencies before GODEBUG=fips140=only is set

* Exclude X25519 curve types when testing in FIPS-140-only mode

* Only modify curve preferences

* Fix up fips140=only integration tests

* Forgot import

* Forgot import

* Fix TestConnectionTLS

* Set GODEBUG=tlsmlkem=0 for tests

* Remove unnecessary changes

* Remove pre-download of Go modules

* Running mage fmt

* Adding CHANGELOG

* Fixing IPv6 address

* Adding missed import

* Go version: s/1.25.2/1.25.4/g

* Rebasing, fixing conflicts, and bumping to Go version 1.25.8

* Bump npcap version

(cherry picked from commit c1cb121)

# Conflicts:
#	go.sum
#	libbeat/docs/version.asciidoc

* Fixing conflicts

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.