[otelmanager] emit starting state in the beginning by VihasMakwana · Pull Request #11234 · elastic/elastic-agent

VihasMakwana · 2025-11-18T15:58:25Z

What does this PR do?

This PR introduces support for emitting a STARTING state when the collector is expect the collector to start.

Why is it important?

Right now, we default to a STOPPED state whenever an error occurs while accessing the healthcheck port. As a result, the elastic-agent status output does not show any monitoring components. If this error occurs consistently every time the collector starts, those components will never appear in elastic-agent status.

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

How to test this PR locally

For mac,

Build agent from this branch
Sign out of docker desktop.
Install and enroll the agent into fleet.
Notice the status. You'll first see Starting state, then Failed state with message OTel manager failed ... process exited with status 1.

Related issues

Closes [beats receivers] OTel manager failed: supervised collector exited with error: Error response from daemon: Sign in to continue using Docker Desktop #11171

mergify · 2025-11-18T15:59:04Z

This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-11-19T06:17:14Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

internal/pkg/otel/translate/status.go

VihasMakwana · 2025-11-19T07:28:54Z

CI failing due to known issue. It will be fixed via #11238

internal/pkg/otel/manager/execution_subprocess.go

swiatekm

I'm not sure I like this approach.

If we need to always emit a STARTING state, then we should do so explicitly, without waiting for the health check first. And if there's an error getting the status, we should set it as an error on the collector instead of doing this. Finally, if some errors from the collector need to be turned into a specific status for all the components, then that should happen separately somewhere in the otel manager.

Does that make sense?

internal/pkg/otel/manager/execution_subprocess.go

VihasMakwana · 2025-11-20T13:51:23Z

The CI has been failing but the test passes on my Mac consistently. Weird.
I've given it a retry.

VihasMakwana · 2025-11-20T14:05:00Z

We already emit a STARTING state here:

elastic-agent/internal/pkg/otel/manager/execution_subprocess.go

Lines 154 to 155 in 2b2dff7

    
           currentStatus := aggregateStatus(componentstatus.StatusStarting, nil) 
        
           r.reportSubprocessCollectorStatus(ctx, statusCh, currentStatus)

We just need to handle that case while agent translation.

swiatekm

I'd like an additional unit test, other than that LGTM.

internal/pkg/otel/translate/status.go

elasticmachine · 2025-11-21T07:01:13Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 795a65c

Failed CI Steps

History

💛 Build #30708 was flaky b378476

cc @VihasMakwana

VihasMakwana · 2025-11-21T07:13:39Z

/test

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut (cherry picked from commit 14c87c2)

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut (cherry picked from commit 14c87c2) # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go # internal/pkg/otel/manager/manager_test.go

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut (cherry picked from commit 14c87c2) Co-authored-by: Vihas Makwana <121151420+VihasMakwana@users.noreply.github.com>

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut

VihasMakwana added 2 commits November 18, 2025 20:45

feat: emit starting state

635500a

test

481a7d3

mergify bot assigned VihasMakwana Nov 18, 2025

Merge branch 'main' into emity-startingstate

491a134

VihasMakwana added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch labels Nov 19, 2025

VihasMakwana marked this pull request as ready for review November 19, 2025 06:17

VihasMakwana requested a review from a team as a code owner November 19, 2025 06:17

VihasMakwana requested review from michel-laterman and ycombinator November 19, 2025 06:17

VihasMakwana changed the title ~~emit starting state if healthcheck port is not yet available~~ [otelmanager] emit starting state if healthcheck is not yet available Nov 19, 2025

VihasMakwana requested review from blakerouse, cmacknz and swiatekm and removed request for michel-laterman and ycombinator November 19, 2025 06:17

VihasMakwana mentioned this pull request Nov 19, 2025

move processor initialization in Start elastic/beats#47686

Draft

6 tasks

rename method

6c279f9

VihasMakwana commented Nov 19, 2025

View reviewed changes

internal/pkg/otel/translate/status.go Outdated Show resolved Hide resolved

Merge branch 'main' into emity-startingstate

b233447

swiatekm reviewed Nov 19, 2025

View reviewed changes

internal/pkg/otel/manager/execution_subprocess.go Outdated Show resolved Hide resolved

swiatekm reviewed Nov 19, 2025

View reviewed changes

VihasMakwana changed the title ~~[otelmanager] emit starting state if healthcheck is not yet available~~ [otelmanager] emit starting state in the beginning Nov 19, 2025

VihasMakwana requested a review from swiatekm November 19, 2025 18:55

VihasMakwana commented Nov 19, 2025

View reviewed changes

internal/pkg/otel/manager/execution_subprocess.go Outdated Show resolved Hide resolved

emit starting state

ad7b7fd

VihasMakwana force-pushed the emity-startingstate branch from 5b4e133 to ad7b7fd Compare November 19, 2025 18:57

fix test

57d98a5

VihasMakwana force-pushed the emity-startingstate branch from 06d154b to 57d98a5 Compare November 20, 2025 10:42

comments

6310b4c

VihasMakwana force-pushed the emity-startingstate branch from 9592c47 to 6310b4c Compare November 20, 2025 13:43

fix case

b378476

elastic deleted a comment from elasticmachine Nov 20, 2025

swiatekm reviewed Nov 20, 2025

View reviewed changes

internal/pkg/otel/translate/status.go Show resolved Hide resolved

ut

795a65c

VihasMakwana requested a review from swiatekm November 21, 2025 06:07

swiatekm approved these changes Nov 21, 2025

View reviewed changes

VihasMakwana merged commit 14c87c2 into elastic:main Nov 21, 2025
21 checks passed

VihasMakwana added the backport-9.1 Automated backport to the 9.1 branch label Nov 21, 2025

mergify bot pushed a commit that referenced this pull request Nov 21, 2025

[otelmanager] emit starting state in the beginning (#11234)

2f7d696

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut (cherry picked from commit 14c87c2)

mergify bot mentioned this pull request Nov 21, 2025

[8.19] (backport #11234) [otelmanager] emit starting state in the beginning #11335

Merged

8 tasks

mergify bot pushed a commit that referenced this pull request Nov 21, 2025

[otelmanager] emit starting state in the beginning (#11234)

906f4b6

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut (cherry picked from commit 14c87c2)

This was referenced Nov 21, 2025

[9.1] (backport #11234) [otelmanager] emit starting state in the beginning #11336

Closed

[9.2] (backport #11234) [otelmanager] emit starting state in the beginning #11337

Merged

hayotbisonai pushed a commit to hayotbisonai/elastic-agent that referenced this pull request Nov 23, 2025

[otelmanager] emit starting state in the beginning (elastic#11234)

a22ad04

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut

swiatekm pushed a commit that referenced this pull request Nov 24, 2025

[otelmanager] emit starting state in the beginning (#11234)

3765113

* feat: emit starting state * test * rename method * emit starting state * fix test * comments * fix case * ut

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[otelmanager] emit starting state in the beginning #11234

[otelmanager] emit starting state in the beginning #11234
VihasMakwana merged 10 commits intoelastic:mainfrom
VihasMakwana:emity-startingstate

VihasMakwana commented Nov 18, 2025 •

edited

Loading

Uh oh!

mergify bot commented Nov 18, 2025

Uh oh!

elasticmachine commented Nov 19, 2025

Uh oh!

Uh oh!

VihasMakwana commented Nov 19, 2025

Uh oh!

Uh oh!

swiatekm left a comment

Uh oh!

Uh oh!

VihasMakwana commented Nov 20, 2025

Uh oh!

VihasMakwana commented Nov 20, 2025

Uh oh!

swiatekm left a comment

Uh oh!

Uh oh!

elasticmachine commented Nov 21, 2025

Uh oh!

VihasMakwana commented Nov 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

VihasMakwana commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

How to test this PR locally

Related issues

Uh oh!

mergify bot commented Nov 18, 2025

Uh oh!

elasticmachine commented Nov 19, 2025

Uh oh!

Uh oh!

VihasMakwana commented Nov 19, 2025

Uh oh!

Uh oh!

swiatekm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VihasMakwana commented Nov 20, 2025

Uh oh!

VihasMakwana commented Nov 20, 2025

Uh oh!

swiatekm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Nov 21, 2025

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

VihasMakwana commented Nov 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VihasMakwana commented Nov 18, 2025 •

edited

Loading