Rewrite the beats receiver log test using common tooling by swiatekm · Pull Request #10153 · elastic/elastic-agent

swiatekm · 2025-09-25T14:26:10Z

What does this PR do?

Re-enables the integration test for comparing logs between beats processes and beats receivers and rewrites it to use normal integration test tooling, making it simpler and more observable:

Instead of uninstalling and reinstalling agent with new configuration, we install it once and just let it reload the configuration, verifying that this happened via status.
Use the normal install process and let agent run as a service instead of running it manually.
Fetches the logs by running elastic-agent logs instead of capturing agent output directly.
Relax the status check to only verify what we care about. This test sets an ES host that doesn't exist, so the status will eventually be degraded, but the test doesn't really care about this.

Why is it important?

This test should be enabled and reliable.

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
~~[ ] I have added tests that prove my fix is effective or that my feature works~~
~~[ ] I have added an entry in ./changelog/fragments using the changelog tool~~
I have added an integration test or an E2E test

Related issues

Closes [Flaky Test]: TestBeatsReceiverLogs – Error: Condition never satisfied #9890

elastic-sonarqube · 2025-09-29T17:18:22Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine · 2025-10-07T15:53:37Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

ycombinator

Just left a couple of minor suggestions/nits. LGTM.

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

elasticmachine · 2025-10-10T17:43:08Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: f830251

Failed CI Steps

x86_64:sudo: default

History

💛 Build #28476 was flaky 8f70b49
💔 Build #28413 failed a976a35
💔 Build #28387 failed 3c5f870
💔 Build #28356 failed 77191ab
💔 Build #28195 failed 437c77c
💔 Build #28059 failed dbffc8e

cc @swiatekm

github-actions · 2025-10-11T17:43:36Z

@Mergifyio backport 8.18 8.19 9.0 9.1 9.2

mergify · 2025-10-11T17:43:59Z

backport 8.18 8.19 9.0 9.1 9.2

✅ Backports have been created

Details

#10504 [8.18] (backport #10153) Rewrite the beats receiver log test using common tooling has been created for branch 8.18 but encountered conflicts
#10505 [8.19] (backport #10153) Rewrite the beats receiver log test using common tooling has been created for branch 8.19
#10506 [9.0] (backport #10153) Rewrite the beats receiver log test using common tooling has been created for branch 9.0 but encountered conflicts
#10507 [9.1] (backport #10153) Rewrite the beats receiver log test using common tooling has been created for branch 9.1 but encountered conflicts
#10508 [9.2] (backport #10153) Rewrite the beats receiver log test using common tooling has been created for branch 9.2

@ycombinator

* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 71ece0d) # Conflicts: # testing/integration/ess/beat_receivers_test.go

@ycombinator

* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 71ece0d)

@ycombinator

* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 71ece0d) # Conflicts: # testing/integration/ess/beat_receivers_test.go

@ycombinator

* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 71ece0d) # Conflicts: # testing/integration/ess/beat_receivers_test.go

@ycombinator

* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 71ece0d)

@ycombinator

…0508) * Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator * Apply suggestion from @ycombinator * Apply suggestion from @ycombinator * Switch assert to required * Fix constants --------- (cherry picked from commit 71ece0d) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

@ycombinator

…0505) * Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator * Apply suggestion from @ycombinator * Apply suggestion from @ycombinator * Switch assert to required * Fix constants --------- (cherry picked from commit 71ece0d) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

@ycombinator

* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

swiatekm added skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Sep 25, 2025

mergify bot assigned swiatekm Sep 25, 2025

swiatekm force-pushed the test/unskip-testbeatsreceiver-logs-install branch 2 times, most recently from 546ed7b to 3b13168 Compare September 29, 2025 13:53

swiatekm mentioned this pull request Sep 30, 2025

[otel] Implement EDOT diagnostics extension #10052

Merged

8 tasks

swiatekm force-pushed the test/unskip-testbeatsreceiver-logs-install branch 2 times, most recently from dbffc8e to 437c77c Compare October 7, 2025 10:18

swiatekm added flaky-test Unstable or unreliable test cases. chore Tasks that just need to be done, they are neither bug, nor enhancements Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Oct 7, 2025

swiatekm marked this pull request as ready for review October 7, 2025 15:53

swiatekm requested a review from a team as a code owner October 7, 2025 15:53

swiatekm requested review from pkoutsovasilis and ycombinator October 7, 2025 15:53

swiatekm mentioned this pull request Oct 7, 2025

[Flaky Test]: TestBeatsReceiverLogs – Error: Condition never satisfied #9890

Closed

swiatekm requested a review from pchila October 7, 2025 15:55

swiatekm mentioned this pull request Oct 7, 2025

Improve observability for TestBeatsReceiverLogs #10030

Closed

3 tasks

ycombinator reviewed Oct 8, 2025

View reviewed changes

Comment thread testing/integration/ess/beat_receivers_test.go Outdated

ycombinator reviewed Oct 8, 2025

View reviewed changes

Comment thread testing/integration/ess/beat_receivers_test.go Outdated

ycombinator reviewed Oct 8, 2025

View reviewed changes

Comment thread testing/integration/ess/beat_receivers_test.go Outdated

ycombinator reviewed Oct 8, 2025

View reviewed changes

Comment thread testing/integration/ess/beat_receivers_test.go Outdated

ycombinator previously approved these changes Oct 8, 2025

View reviewed changes

swiatekm dismissed ycombinator’s stale review via eb17067 October 8, 2025 18:29

swiatekm requested a review from ycombinator October 8, 2025 18:30

ycombinator previously approved these changes Oct 8, 2025

View reviewed changes

swiatekm force-pushed the test/unskip-testbeatsreceiver-logs-install branch 2 times, most recently from 3c5f870 to a976a35 Compare October 9, 2025 09:56

swiatekm requested a review from ycombinator October 10, 2025 12:04

swiatekm and others added 9 commits October 10, 2025 17:34

Rewrite the beats receiver log test using common tooling

e993324

Expect the outputs to be degraded

f3a01b0

Relax checks

80ec158

Fix assertion

fa52248

Apply suggestion from @ycombinator

4281d43

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

Apply suggestion from @ycombinator

5e48d67

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

Apply suggestion from @ycombinator

312fff5

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

Switch assert to required

bc43cfc

Fix constants

f830251

swiatekm force-pushed the test/unskip-testbeatsreceiver-logs-install branch from 8f70b49 to f830251 Compare October 10, 2025 15:34

ycombinator approved these changes Oct 10, 2025

View reviewed changes

swiatekm merged commit 71ece0d into main Oct 11, 2025
21 checks passed

swiatekm deleted the test/unskip-testbeatsreceiver-logs-install branch October 11, 2025 17:43

mergify bot mentioned this pull request Oct 11, 2025

[8.18] (backport #10153) Rewrite the beats receiver log test using common tooling #10504

Closed

4 tasks

mergify bot mentioned this pull request Oct 11, 2025

[8.19] (backport #10153) Rewrite the beats receiver log test using common tooling #10505

Merged

4 tasks

mergify bot mentioned this pull request Oct 11, 2025

[9.0] (backport #10153) Rewrite the beats receiver log test using common tooling #10506

Closed

4 tasks

mergify bot mentioned this pull request Oct 11, 2025

[9.1] (backport #10153) Rewrite the beats receiver log test using common tooling #10507

Merged

4 tasks

mergify bot mentioned this pull request Oct 11, 2025

[9.2] (backport #10153) Rewrite the beats receiver log test using common tooling #10508

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite the beats receiver log test using common tooling#10153

Rewrite the beats receiver log test using common tooling#10153
swiatekm merged 9 commits intomainfrom
test/unskip-testbeatsreceiver-logs-install

swiatekm commented Sep 25, 2025 •

edited

Loading

Uh oh!

elastic-sonarqube bot commented Sep 29, 2025

Uh oh!

elasticmachine commented Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ycombinator left a comment

Uh oh!

elasticmachine commented Oct 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

mergify bot commented Oct 11, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

swiatekm commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Related issues

Uh oh!

elastic-sonarqube bot commented Sep 29, 2025

Quality Gate passed

Uh oh!

elasticmachine commented Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ycombinator left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 10, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

mergify bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

swiatekm commented Sep 25, 2025 •

edited

Loading

mergify bot commented Oct 11, 2025 •

edited

Loading