Quote the labels example, to avoid the YAML interpreter interpreting it#782
Merged
webmat merged 2 commits intoelastic:masterfrom Mar 11, 2020
Merged
Quote the labels example, to avoid the YAML interpreter interpreting it#782webmat merged 2 commits intoelastic:masterfrom
labels example, to avoid the YAML interpreter interpreting it#782webmat merged 2 commits intoelastic:masterfrom
Conversation
3 tasks
Contributor
Author
|
I don't think this warrants a patch release. I suggest you replace the problem section of the 1.5 YML in Beats with this exact output (https://github.com/elastic/ecs/pull/782/files#diff-5c26e320ef5dca7ad0441c5eeb32dba3R33), @adriansr. This will avoid an unnecessary diff when comes time to introduce 1.6 in Beats. WDYT? |
labels example, to avoid the YAML interpreter interpret it.labels example, to avoid the YAML interpreter interpreting it
adriansr
approved these changes
Mar 11, 2020
Contributor
adriansr
left a comment
There was a problem hiding this comment.
Thanks for patching! I will update on the beats side with the same change
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.