Merged
Conversation
kgeller
approved these changes
Feb 2, 2023
Member
kgeller
left a comment
There was a problem hiding this comment.
LGTM
I tweaked the changelog to put your entry under 8.7 since you added that label to the PR. If that's a mistake, feel free to put it back and add the 8.8 label
gabriellandau
approved these changes
Feb 2, 2023
marc-gr
added a commit
to marc-gr/ecs
that referenced
this pull request
Feb 8, 2023
* Adding library category to the schema * Change log * revert accidental commit * Correct gitignore * ignore from main to correct line endings, etc * make / make test / git add / commit / push * Update CHANGELOG.next.md --------- Co-authored-by: mo <jonathan.molinatto@elastic.co> Co-authored-by: Kylie Geller <kylie.geller@elastic.co> Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
marc-gr
added a commit
that referenced
this pull request
Feb 8, 2023
* Adding library category to the schema * Change log * revert accidental commit * Correct gitignore * ignore from main to correct line endings, etc * make / make test / git add / commit / push * Update CHANGELOG.next.md --------- Co-authored-by: Michelle Bennett <39916526+softengchick@users.noreply.github.com> Co-authored-by: mo <jonathan.molinatto@elastic.co> Co-authored-by: Kylie Geller <kylie.geller@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the currently used by Endpoint category value of "library".
make test?makeand committed those changes?